feat: support for usb cameras and onvif zoom functionality in camera mgmt app #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2023
presatish
reviewed
Feb 27, 2023
application-services/custom/camera-management/appcamera/commands.go
Outdated
Show resolved
Hide resolved
mpvats-intel
approved these changes
Feb 27, 2023
mpvats-intel
approved these changes
Feb 27, 2023
mpvats-intel
approved these changes
Feb 27, 2023
mpvats-intel
previously approved these changes
Feb 28, 2023
ajcasagrande
changed the title
mpvats-intel
previously approved these changes
Feb 28, 2023
brianointel
reviewed
Feb 28, 2023
application-services/custom/camera-management/appcamera/evam.go
Outdated
Show resolved
Hide resolved
brianointel
reviewed
Feb 28, 2023
application-services/custom/camera-management/appcamera/evam.go
Outdated
Show resolved
Hide resolved
brianointel
reviewed
Feb 28, 2023
...ervices/custom/camera-management/web-ui/src/app/camera-selector/camera-selector.component.ts
Outdated
Show resolved
Hide resolved
ajcasagrande
dismissed stale reviews from brianointel and mpvats-intel
via
a426086
ajcasagrande
force-pushed
the
implement-zoom
branch
from
a426086 to
cbc42d3
Compare
|
Squashed and fixed DCO |
application-services/custom/camera-management/appcamera/evam.go
Outdated
Show resolved
Hide resolved
ajcasagrande
requested review from
presatish,
mpvats-intel,
brianointel and
ChristianDarr-personal
and removed request for
presatish,
mpvats-intel and
brianointel
ajcasagrande
requested review from
brianointel,
mpvats-intel,
ChristianDarr-personal and
presatish
and removed request for
ChristianDarr-personal,
brianointel,
mpvats-intel and
presatish
presatish
reviewed
Mar 6, 2023
|
Most of it looks good. I have added a comment for the docs. |
presatish
previously approved these changes
Mar 6, 2023
presatish
reviewed
Mar 6, 2023
ajcasagrande
dismissed stale reviews from presatish and ChristianDarr-personal
via
ac26eb3
…mgmt app Signed-off-by: Anthony Casagrande <[email protected]> Signed-off-by: Christian Darr <[email protected]> Signed-off-by: Brian Osburn <[email protected]> Co-authored-by: Brian Osburn <[email protected]> Co-authored-by: Christian Darr <[email protected]>
ajcasagrande
force-pushed
the
implement-zoom
branch
from
8c10a6e to
460dac7
Compare
5 tasks
brianointel
pushed a commit
to EdgeX-Camera-Management/edgex-examples
that referenced
this pull request
Apr 26, 2023
Signed-off-by: Bryon Nevis <[email protected]> Signed-off-by: Bryon Nevis <[email protected]> fix: remove duplicated path from query uri (edgexfoundry#182) Signed-off-by: Anthony Casagrande <[email protected]> fix: Modify pan tilt function by getting pan/tilt range dynamically (edgexfoundry#181) * fix: Get pan/tilt values dynamically Signed-off-by: preethi-satishcandra <[email protected]> feat: support for usb cameras and onvif zoom functionality in camera mgmt app (edgexfoundry#184) Signed-off-by: Anthony Casagrande <[email protected]> Signed-off-by: Christian Darr <[email protected]> Signed-off-by: Brian Osburn <[email protected]> Co-authored-by: Brian Osburn <[email protected]> Co-authored-by: Christian Darr <[email protected]> feat: updated app service with target type Signed-off-by: brianointel <[email protected]> feat: added code for pipeline function Signed-off-by: brianointel <[email protected]> feat: template code for funtion pipelines by topic Signed-off-by: brianointel <[email protected]> feat: added initial event handler Signed-off-by: brianointel <[email protected]> feat: more device messagebus progress Signed-off-by: brianointel <[email protected]> feat: message bus code Signed-off-by: Brian Osburn <[email protected]> feat: messagebus progress Signed-off-by: Brian Osburn <[email protected]> feat: created defaultpipelinefunction Signed-off-by: Brian Osburn <[email protected]> feat: try to start pipelines on startup Signed-off-by: brianointel <[email protected]> feat: small changes Signed-off-by: Brian Osburn <[email protected]> feat: pr updates Signed-off-by: Brian Osburn <[email protected]> feat: added config params Signed-off-by: Brian Osburn <[email protected]> feat: pr updates Signed-off-by: Brian Osburn <[email protected]> feat: pr updates Signed-off-by: Brian Osburn <[email protected]> feat: pr updates Signed-off-by: Brian Osburn <[email protected]> feat: handle device delete event to stop pipeline also some minor refactoring Signed-off-by: Anthony Casagrande <[email protected]>
brianointel
pushed a commit
to EdgeX-Camera-Management/edgex-examples
that referenced
this pull request
Apr 27, 2023
* feat: Update device service example for Levski Signed-off-by: Leonard Goodell <[email protected]> build: Update HELM Chart to Levski released images (edgexfoundry#140) Signed-off-by: Leonard Goodell <[email protected]> Signed-off-by: Leonard Goodell <[email protected]> feat: added support for shared and non-shared volumes Close edgexfoundry#92 Signed-off-by: Kyle Morton <[email protected]> fix: EdgeX UI in kubernetes was not binding container network IF Signed-off-by: Bryon Nevis <[email protected]> feat: Added support for onvif and usb camera Closes edgexfoundry#107 Signed-off-by: Kyle Morton <[email protected]> feat: Added support for modbus-simulator Signed-off-by: Kyle Morton <[email protected]> feat: Add support in helm for ds-mqtt and mqtt-broker Signed-off-by: Kyle Morton <[email protected]> feat: Add support in helm for ds-modbus Signed-off-by: Kyle Morton <[email protected]> feat: Add support in helm for ds-bacnet Signed-off-by: Kyle Morton <[email protected]> feat: Add support in helm for ds-snmp Signed-off-by: Kyle Morton <[email protected]> feat: Add support in helm for ds-rfid-llrp Signed-off-by: Kyle Morton <[email protected]> feat: Add support in helm for ds-gpio Signed-off-by: Kyle Morton <[email protected]> feat: Add support in helm for asc-mqtt and asc-httpexport Signed-off-by: Kyle Morton <[email protected]> feat: Add support in helm for asc-sample, asc-metrics, and as-llrp Signed-off-by: Kyle Morton <[email protected]> fix: Updated device-onvif-camera and device-usb-camera directory and volume (edgexfoundry#156) Signed-off-by: Kyle Morton <[email protected]> Signed-off-by: Kyle Morton <[email protected]> Co-authored-by: Kyle Morton <[email protected]> fix: added service for edgex-ui (edgexfoundry#162) Signed-off-by: Kyle Morton <[email protected]> Signed-off-by: Kyle Morton <[email protected]> Co-authored-by: Kyle Morton <[email protected]> feat: Added support for nats (edgexfoundry#163) Signed-off-by: Kyle Morton <[email protected]> Signed-off-by: Kyle Morton <[email protected]> Co-authored-by: Kyle Morton <[email protected]> fix: Updated health checks to appropriate protocol (edgexfoundry#164) Signed-off-by: Kyle Morton <[email protected]> Signed-off-by: Kyle Morton <[email protected]> Co-authored-by: Kyle Morton <[email protected]> fix: added kuiper-connections and kuipers-sources volumes (edgexfoundry#165) Signed-off-by: Kyle Morton <[email protected]> Signed-off-by: Kyle Morton <[email protected]> Co-authored-by: Kyle Morton <[email protected]> fix: Correct addConsulRoles list (edgexfoundry#166) Signed-off-by: Kyle Morton <[email protected]> Signed-off-by: Kyle Morton <[email protected]> Co-authored-by: Kyle Morton <[email protected]> feat: Support optional hostPort binding (edgexfoundry#167) Signed-off-by: Kyle Morton <[email protected]> Signed-off-by: Kyle Morton <[email protected]> Co-authored-by: Kyle Morton <[email protected]> feat: Expose services on a per-service basis (edgexfoundry#169) Signed-off-by: Kyle Morton <[email protected]> Signed-off-by: Kyle Morton <[email protected]> Co-authored-by: Kyle Morton <[email protected]> fix: Added container port names (edgexfoundry#170) Signed-off-by: Kyle Morton <[email protected]> Signed-off-by: Kyle Morton <[email protected]> Co-authored-by: Kyle Morton <[email protected]> feat!: Remove system-mgmt-agent (deprecated) (edgexfoundry#175) BREAKING CHANGE: Remove system-mgmt-agent (deprectated) Signed-off-by: Bryon Nevis <[email protected]> Signed-off-by: Bryon Nevis <[email protected]> docs: add link to camera app example video Signed-off-by: Anthony Casagrande <[email protected]> feat: Add Helm security scanners (edgexfoundry#174) Signed-off-by: Bryon Nevis <[email protected]> Signed-off-by: Bryon Nevis <[email protected]> fix: remove duplicated path from query uri (edgexfoundry#182) Signed-off-by: Anthony Casagrande <[email protected]> fix: Modify pan tilt function by getting pan/tilt range dynamically (edgexfoundry#181) * fix: Get pan/tilt values dynamically Signed-off-by: preethi-satishcandra <[email protected]> feat: support for usb cameras and onvif zoom functionality in camera mgmt app (edgexfoundry#184) Signed-off-by: Anthony Casagrande <[email protected]> Signed-off-by: Christian Darr <[email protected]> Signed-off-by: Brian Osburn <[email protected]> Co-authored-by: Brian Osburn <[email protected]> Co-authored-by: Christian Darr <[email protected]> feat: updated app service with target type Signed-off-by: brianointel <[email protected]> feat: added code for pipeline function Signed-off-by: brianointel <[email protected]> feat: template code for funtion pipelines by topic Signed-off-by: brianointel <[email protected]> feat: added initial event handler Signed-off-by: brianointel <[email protected]> feat: more device messagebus progress Signed-off-by: brianointel <[email protected]> feat: message bus code Signed-off-by: Brian Osburn <[email protected]> feat: messagebus progress Signed-off-by: Brian Osburn <[email protected]> feat: created defaultpipelinefunction Signed-off-by: Brian Osburn <[email protected]> feat: try to start pipelines on startup Signed-off-by: brianointel <[email protected]> feat: small changes Signed-off-by: Brian Osburn <[email protected]> feat: pr updates Signed-off-by: Brian Osburn <[email protected]> feat: added config params Signed-off-by: Brian Osburn <[email protected]> feat: pr updates Signed-off-by: Brian Osburn <[email protected]> feat: pr updates Signed-off-by: Brian Osburn <[email protected]> feat: pr updates Signed-off-by: Brian Osburn <[email protected]> feat: handle device delete event to stop pipeline Signed-off-by: brianointel <[email protected]> also some minor refactoring Signed-off-by: Anthony Casagrande <[email protected]> fix: pr updates Signed-off-by: Brian Osburn <[email protected]> refactor: fix imports from merge Signed-off-by: Anthony Casagrande <[email protected]> feat: pr updates Signed-off-by: Brian Osburn <[email protected]> fix: updated funtion name Signed-off-by: Brian Osburn <[email protected]> feat: Add Helm security scanners (edgexfoundry#174) Signed-off-by: Bryon Nevis <[email protected]> Signed-off-by: Bryon Nevis <[email protected]> fix: remove duplicated path from query uri (edgexfoundry#182) Signed-off-by: Anthony Casagrande <[email protected]> fix: Modify pan tilt function by getting pan/tilt range dynamically (edgexfoundry#181) * fix: Get pan/tilt values dynamically Signed-off-by: preethi-satishcandra <[email protected]> feat: support for usb cameras and onvif zoom functionality in camera mgmt app (edgexfoundry#184) Signed-off-by: Anthony Casagrande <[email protected]> Signed-off-by: Christian Darr <[email protected]> Signed-off-by: Brian Osburn <[email protected]> Co-authored-by: Brian Osburn <[email protected]> Co-authored-by: Christian Darr <[email protected]> feat: updated app service with target type Signed-off-by: brianointel <[email protected]> feat: added code for pipeline function Signed-off-by: brianointel <[email protected]> feat: template code for funtion pipelines by topic Signed-off-by: brianointel <[email protected]> feat: added initial event handler Signed-off-by: brianointel <[email protected]> feat: more device messagebus progress Signed-off-by: brianointel <[email protected]> feat: message bus code Signed-off-by: Brian Osburn <[email protected]> feat: messagebus progress Signed-off-by: Brian Osburn <[email protected]> feat: created defaultpipelinefunction Signed-off-by: Brian Osburn <[email protected]> feat: try to start pipelines on startup Signed-off-by: Brian Osburn <[email protected]> feat: small changes Signed-off-by: Brian Osburn <[email protected]> feat: pr updates Signed-off-by: Brian Osburn <[email protected]> feat: added config params Signed-off-by: Brian Osburn <[email protected]> feat: pr updates Signed-off-by: Brian Osburn <[email protected]> feat: pr updates Signed-off-by: Brian Osburn <[email protected]> feat: pr updates Signed-off-by: Brian Osburn <[email protected]> feat: handle device delete event to stop pipeline also some minor refactoring Signed-off-by: Anthony Casagrande <[email protected]> fix: pr updates Signed-off-by: Brian Osburn <[email protected]> refactor: fix imports from merge Signed-off-by: Anthony Casagrande <[email protected]> feat: pr updates Signed-off-by: Brian Osburn <[email protected]> fix: updated funtion name Signed-off-by: Brian Osburn <[email protected]> fix: corrected error message placement Signed-off-by: brianointel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
Testing Instructions
NOTE: Not fixing DCO/squashing/force-pushing until reviews are completed. This helps the people who have already reviewed it to better track what has changed.