Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose services on a per-service basis #169

Merged
merged 1 commit into from
Dec 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ spec:
port: {{.Values.edgex.port.appservice.externalmqtttrigger}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.appservice.externalmqtttrigger}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.appservice.externalmqtttrigger}}
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
port: {{.Values.edgex.port.appservice.httpexport}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.appservice.httpexport}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.appservice.httpexport}}

Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ spec:
port: {{.Values.edgex.port.appservice.metricsinfluxdb}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.appservice.metricsinfluxdb}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.appservice.metricsinfluxdb}}
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ spec:
port: {{.Values.edgex.port.appservice.mqttexport}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.appservice.mqttexport}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.appservice.mqttexport}}
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ spec:
port: {{.Values.edgex.port.appservice.rfidllrpinventory}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.appservice.rfidllrpinventory}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.appservice.rfidllrpinventory}}
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ spec:
port: {{.Values.edgex.port.appservice.appsample}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.appservice.appsample}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.appservice.appsample}}
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ spec:
port: {{.Values.edgex.port.appservice.rules}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.appservice.rules}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.appservice.rules}}
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ spec:
{{- end }}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.consul}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.consul}}
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ spec:
port: {{.Values.edgex.port.core.command}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.core.command}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.core.command}}
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ spec:
port: {{.Values.edgex.port.core.data}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.core.data}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.core.data}}
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
port: {{.Values.edgex.port.device.bacnet}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.device.bacnet}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.device.bacnet}}

Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
port: {{.Values.edgex.port.device.gpio}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.device.gpio}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.device.gpio}}

Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
port: {{.Values.edgex.port.device.modbus}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.device.modbus}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.device.modbus}}

Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
port: {{.Values.edgex.port.device.mqtt}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.device.mqtt}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.device.mqtt}}

Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
port: {{.Values.edgex.port.device.onvifcamera}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.device.onvifcamera}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.device.onvifcamera}}

Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ spec:
port: {{.Values.edgex.port.device.rest}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.device.rest}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.device.rest}}
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
port: {{.Values.edgex.port.device.rfidllrp}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.device.rfidllrp}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.device.rfidllrp}}

Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
port: {{.Values.edgex.port.device.snmp}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.device.snmp}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.device.snmp}}

Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
port: {{.Values.edgex.port.device.onvifcamera}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.device.usbcamera}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.device.usbcamera}}

Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
port: {{.Values.edgex.port.device.virtual}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.device.virtual}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.device.virtual}}

Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ spec:
port: {{.Values.edgex.port.ekuiper}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.ekuiper}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.ekuiper}}
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
port: {{.Values.edgex.port.core.metadata}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.core.metadata}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.core.metadata}}

Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
port: {{.Values.edgex.port.modbussimulator}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.modbussimulator}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.modbussimulator}}

Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
port: {{.Values.edgex.port.mqttbroker}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.mqttbroker}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.mqttbroker}}

Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
port: {{.Values.edgex.port.natsserver}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.natsserver}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.natsserver}}

Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,4 @@ spec:
port: {{.Values.edgex.port.redis}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.redis}}
type: {{.Values.expose.type}}
status:
loadBalancer: {}
type: {{.Values.expose.type.redis}}
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ spec:
port: {{ .Values.edgex.bootstrap.port.start }}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.bootstrapper}}
type: ClusterIP
type: {{.Values.expose.type.bootstrapper}}
# Do not allocate cluster IP - point DNS directly at the Pod IP - ignore targetPort's
clusterIP: None
{{- end}}
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ spec:
port: {{.Values.edgex.port.support.notifications}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.support.notifications}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.support.notifications}}
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ spec:
port: {{.Values.edgex.port.support.scheduler}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.support.scheduler}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.support.scheduler}}
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ spec:
port: {{.Values.edgex.port.system}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.system}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.system}}
2 changes: 1 addition & 1 deletion deployment/helm/templates/edgex-ui/edgex-ui-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ spec:
port: {{.Values.edgex.port.ui}}
selector:
org.edgexfoundry.service: {{.Values.edgex.app.ui}}
type: {{.Values.expose.type}}
type: {{.Values.expose.type.ui}}
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ spec:
port: 8200
selector:
org.edgexfoundry.service: {{.Values.edgex.app.vault}}
type: ClusterIP
type: {{.Values.expose.type.vault}}
{{- end}}
40 changes: 38 additions & 2 deletions deployment/helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,44 @@
# Declare variables to be passed into your templates.

expose:
# Option value: ClusterIP/NodePort/LoadBalancer
type: ClusterIP
type:
# Option value: ClusterIP/NodePort/LoadBalancer
core:
command: ClusterIP
data: ClusterIP
metadata: ClusterIP
support:
notifications: ClusterIP
scheduler: ClusterIP
appservice:
rules: ClusterIP
mqttexport: ClusterIP
httpexport: ClusterIP
appsample: ClusterIP
metricsinfluxdb: ClusterIP
rfidllrpinventory: ClusterIP
externalmqtttrigger: ClusterIP
device:
virtual: ClusterIP
rest: ClusterIP
usbcamera: ClusterIP
onvifcamera: ClusterIP
mqtt: ClusterIP
modbus: ClusterIP
bacnet: ClusterIP
snmp: ClusterIP
rfidllrp: ClusterIP
gpio: ClusterIP
ui: NodePort
system: ClusterIP
consul: NodePort
redis: ClusterIP
ekuiper: ClusterIP
modbussimulator: ClusterIP
mqttbroker: ClusterIP
natsserver: ClusterIP
bootstrapper: ClusterIP
vault: ClusterIP

# edgex defines a set of configuration properties for application-level concerns
edgex:
Expand Down