Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for shared and non-shared volumes #141

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

drkfmorton
Copy link
Contributor

@drkfmorton drkfmorton commented Nov 10, 2022

Closes #92
Signed-off-by: Kyle Morton [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)

Testing Instructions

Copy link
Collaborator

@bnevis-i bnevis-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested 3 vectors:

  • hostpath only
  • rwo nonshared volumes and rwx shared volumes
  • rwx for both
  • (didn't test rwx nonshared and rwo shared since that is silly)

@bnevis-i bnevis-i merged commit 4ef49e6 into edgexfoundry:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm deployment: Add support for additional container storage engines
2 participants