Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Addressable With Protocols #9

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

michaelestrin
Copy link
Member

In API walk through, replaced addressable with protocols in device
creation call. Example did not have a protocols field and result of
POST was a no supporting protocol specified for device result.

#8

Signed-off-by: Michael W. Estrin [email protected]

Copy link
Member

@iain-anderson iain-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change the text immediately above which refers to Addressable still

mhall119
mhall119 previously approved these changes Jul 12, 2019
Copy link
Contributor

@mhall119 mhall119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In API walk through, replaced addressable with protocols in device
creation call.  Example did not have a protocols field and result of
POST was a _no supporting protocol specified for device_ result.

edgexfoundry#8

Signed-off-by: Michael W. Estrin <[email protected]>
@michaelestrin
Copy link
Member Author

Need to change the text immediately above which refers to Addressable still

Done.

@michaelestrin
Copy link
Member Author

@iain-anderson Please push the merge button -- this is the same as #10 (Edinburgh branch) but for master.

@iain-anderson iain-anderson merged commit 9c1759d into edgexfoundry:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants