Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Built-in functions documentation for Ireland #436

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/master/.github/Contributing.md.

What is the current behavior?

App SDK Built-in functions doc not current for Ireland

Issue Number: #391, #388, #302, #349, #351, #340

What is the new behavior?

App SDK Built-in functions doc now current for Ireland

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

AlexCuse
AlexCuse previously approved these changes Jun 26, 2021
Copy link
Contributor

@AlexCuse AlexCuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Walt-Intel
Walt-Intel previously approved these changes Jun 28, 2021
Copy link

@Walt-Intel Walt-Intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor tweak.

docs_src/microservices/application/BuiltIn.md Outdated Show resolved Hide resolved
@lenny-goodell lenny-goodell dismissed stale reviews from Walt-Intel and AlexCuse via 3238a77 June 28, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants