Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update App Service Configurable documentation for Ireland changes #422

Merged
merged 5 commits into from
Jun 18, 2021

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/master/.github/Contributing.md.

What is the current behavior?

App Service Configurable documentation not update for Ireland changes

Issue Number: #376 & #356

What is the new behavior?

App Service Configurable documentation now update for Ireland changes

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

AlexCuse
AlexCuse previously approved these changes Jun 18, 2021
Copy link
Contributor

@AlexCuse AlexCuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brian-intel
brian-intel previously approved these changes Jun 18, 2021
@lenny-goodell lenny-goodell dismissed stale reviews from brian-intel, Walt-Intel, and AlexCuse via 40584f6 June 18, 2021 18:26
@AlexCuse AlexCuse self-requested a review June 18, 2021 18:31
@lenny-goodell lenny-goodell merged commit b18e99a into edgexfoundry:master Jun 18, 2021
@lenny-goodell lenny-goodell deleted the asc-updates branch June 18, 2021 18:37
edgex-jenkins added a commit that referenced this pull request Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASC: Document use of profiles App Services: Update ASC documentation Ireland changes
4 participants