Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(security): Add custom spire config env variable #1041

Merged
merged 2 commits into from
Apr 27, 2023
Merged

feat(security): Add custom spire config env variable #1041

merged 2 commits into from
Apr 27, 2023

Conversation

ejlee3
Copy link
Contributor

@ejlee3 ejlee3 commented Apr 26, 2023

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)

@ejlee3 ejlee3 mentioned this pull request Apr 26, 2023
Merged
5 tasks
lenny-goodell
lenny-goodell reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once resolve @jim-wang-intel 's comment

bnevis-i
bnevis-i reviewed Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@bnevis-i bnevis-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusting env var to be consistent with comment I made in edgex-go#4533. Also, throwing in explicit quotes just to be sure the yaml parser treats it as a string.

docs_src/security/Ch-DelayedStartServices.md Outdated Show resolved Hide resolved
@ejlee3
fix: address pr comments
49f49d5 
Signed-off-by: Elizabeth J Lee <[email protected]>
lenny-goodell
lenny-goodell approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejlee3 ejlee3 merged commit 496a756 into edgexfoundry:main Apr 27, 2023
@ejlee3 ejlee3 deleted the add-custom-security-spire-var branch April 27, 2023 16:32
edgex-jenkins added a commit that referenced this pull request Apr 27, 2023
@edgex-jenkins
ci: Merge pull request #1041 from ejlee3/add-custom-security-spire-var
1df1352 
Signed-off-by: edgex-jenkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenny-goodell lenny-goodell lenny-goodell approved these changes

@jim-wang-intel jim-wang-intel jim-wang-intel approved these changes

@bnevis-i bnevis-i bnevis-i approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ejlee3 @bnevis-i @jim-wang-intel @lenny-goodell