Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace old Scheduler service with cron Scheduler service #478

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

weichou1229
Copy link
Member

BREAKING CHANGE: the cron scheduler name and key changed

Replace the old Scheduler service with the new cron Scheduler service

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

BREAKING CHANGE: the cron scheduler name and key changed

Replace the old Scheduler service with the new cron Scheduler service

Signed-off-by: bruce <[email protected]>
@weichou1229 weichou1229 requested a review from cherrycl November 11, 2024 14:24
Copy link
Contributor

@cherrycl cherrycl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weichou1229 weichou1229 marked this pull request as ready for review November 12, 2024 10:15
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 1a73aa2 into edgexfoundry:main Nov 12, 2024
3 checks passed
@weichou1229 weichou1229 deleted the sched-refactor branch November 19, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants