fix: portainer docker rootless #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed how docker rootless environment is resolved and env var is assigned Signed-off-by: jakeiotechsys <[email protected]>
Corrected comment Signed-off-by: jakeiotechsys <[email protected]>
|
recheck |
|
recheck |
2 similar comments
|
recheck |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #460
PR Checklist
BREAKING CHANGE:describing the break)docs change not required as this is a bug fix.
Testing Instructions
Navigate to the compose-builder folder. Make sure you are running in a rootless docker environment. Run
make portainer. After portainer has started rundocker inspect portainer. Make sure the docker socket bind mount is in the user's space instead of the sudo docker socket location. Navigate to the portainer localhost web page and make sure it can connect to the docker socket and see other running containers.