-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Docker rootless #451
Conversation
b96e896
to
6956c05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please execute the make build
after updating yml files under compose-builder
to make sure all docker-compose files are updated for this change.
Also make sure every commit
and the PR title
is semantic.
@jakeiotechsys Are you working on this comment? Please also squash the commits. |
recheck |
a06e506
to
db12086
Compare
recheck |
718f5b2
to
02c5593
Compare
Modified vault compose entries to disable memory locking feature of vault. This lets us run vault in a rootless docker environment Signed-off-by: jakeiotechsys <[email protected]>
Signed-off-by: jakeiotechsys <[email protected]>
Added user ID resolver in Makefile and docker sock mounts for portainer and security-spire-config container Signed-off-by: jakeiotechsys <[email protected]>
added user ID resolver in Makefile Signed-off-by: jakeiotechsys <[email protected]>
Added test for docker rootless mode in makefiles Signed-off-by: jakeiotechsys <[email protected]>
Fixed up left over lines Signed-off-by: jakeiotechsys <[email protected]>
Updated readme files Signed-off-by: jakeiotechsys <[email protected]>
made makefile resolve docker environment Signed-off-by: jakeiotechsys <[email protected]>
Updated compose files for root dir Signed-off-by: jakeiotechsys <[email protected]>
added total system memory resolver to Makefile Signed-off-by: jakeiotechsys <[email protected]>
added generated files Signed-off-by: jakeiotechsys <[email protected]>
Removed debug Signed-off-by: jakeiotechsys <[email protected]>
Fixed vault storage backend issue causing vault not to boot Signed-off-by: jakeiotechsys <[email protected]>
Commiting generated files Signed-off-by: jakeiotechsys <[email protected]>
Fixed makefile delayed-start gen syntax issues Signed-off-by: jakeiotechsys <[email protected]>
change yaml multi line Indicator Signed-off-by: weichou1229 <[email protected]>
Removed multiline formatting Signed-off-by: jakeiotechsys <[email protected]>
add default vault config Signed-off-by: weichou1229 <[email protected]>
02c5593
to
f1c36f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #452
Feat: Run Edgex in a rootless docker environment for added security
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Docs updates are to come soon
Testing Instructions
Test on ubuntu linux with both a rootless docker environment, and a rootful docker environment. Start edgex using make run, and start portainer with make portainer from within the compose-builder folder.
Get the auth token
token=$(make get-token)
Ping Core-Data for Connection Testing
curl -k -H "Authorization: Bearer $token" https://localhost:8443/core-data/api/v3/ping
Get Event Values for Virtual Device
curl -H "Authorization: Bearer $token" http://localhost:59880/api/v3/event/device/name/Random-Integer-Device
Check Core Command for Available Commands
curl -H "Authorization: Bearer $token" http://localhost:59882/api/v3/device/name/Random-Integer-Device
Get Current Value for Int16 Device
curl -H "Authorization: Bearer $token" http://localhost:59882/api/v3/device/name/Random-Integer-Device/Int16
Set the Value of WriteInt16
Verify the Updated Value of Int16
curl -H "Authorization: Bearer $token" http://localhost:59882/api/v3/device/name/Random-Integer-Device/Int16
Run Modbus Simulator Container using edge-central docs
Map TCP to TTY Port File
Upload Device Profile
Create Device Entity
Test Modbus Device
curl -H "Authorization: Bearer $token" http://localhost:59882/api/v3/device/name/Power-Submeter-Device/Configuration
Navigate to portainer
Using a web browser, go to localhosty:9000 and log in with default portainer credentials