Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add MessageBus config for all core/support services #263

Closed

Conversation

lenny-goodell
Copy link
Member

This is in preparation from when these service's publish Service Metrics or System Events to the MessageBus

closes #258

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

Run make gen no-secty
Verify all core/support services have the MESSAGEQUEUE_HOST=edgex-redis override
Run make gen no-secty mqtt-bus
Verify all core/support services have the following env overrides:

  • MESSAGEQUEUE_AUTHMODE: none
  • MESSAGEQUEUE_HOST: edgex-mqtt-broker
  • MESSAGEQUEUE_OPTIONAL_CLIENTID:
  • MESSAGEQUEUE_PORT: '1883'
  • MESSAGEQUEUE_PROTOCOL: tcp
  • MESSAGEQUEUE_TYPE: mqtt

Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell
Copy link
Member Author

Previous PR in now pass, so this one is not needed,

@lenny-goodell lenny-goodell deleted the messagebus-for-all-2 branch October 26, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MessageBus config for all core/support services
2 participants