feat: Add MessageBus config for all core/support services #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-wang-intel
previously approved these changes
Jul 27, 2022
|
recheck |
|
recheck |
1 similar comment
|
recheck |
|
@cherrycl please help check the smoke test when you have time |
5 tasks
lenny-goodell
dismissed stale reviews from cloudxxx8 and jim-wang-intel
via
08ec136
jim-wang-intel
previously approved these changes
Jul 29, 2022
|
recheck |
|
When triggering the smoke test, TAF always got incorrect |
lenny-goodell
force-pushed
the
messagebus-for-all
branch
from
08ec136 to
c2c6a1e
Compare
This is in preparation from when these service's publish Service Metrics or System Events to the MessageBus closes edgexfoundry#258 fix: Fix service key for scalability-test-mqtt-export to have app- prefix Signed-off-by: Leonard Goodell <[email protected]>
lenny-goodell
force-pushed
the
messagebus-for-all
branch
from
c2c6a1e to
a9f3d90
Compare
|
Hum, I rebased an this one passed. |
jim-wang-intel
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation from when these service's publish Service Metrics or System Events to the MessageBus
closes #258
Signed-off-by: Leonard Goodell [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
Run
make gen no-sectyVerify all core/support services have the
MESSAGEQUEUE_HOST=edgex-redisoverrideRun
make gen no-secty mqtt-busVerify all core/support services have the following env overrides: