Skip to content

Commit

Permalink
fix: Remove redis and consul files and script
Browse files Browse the repository at this point in the history
Signed-off-by: Cherry Wang <[email protected]>
  • Loading branch information
cherrycl committed Nov 4, 2024
1 parent 34df73e commit 2bccd51
Show file tree
Hide file tree
Showing 32 changed files with 139 additions and 449 deletions.
5 changes: 0 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,3 @@ get-token:
DEV=$(DEV) \
ARCH=$(ARCH) \
cd ./compose-builder; sh get-api-gateway-token.sh

get-consul-acl-token:
DEV=$(DEV) \
ARCH=$(ARCH) \
cd ./compose-builder; sh ./get-consul-acl-token.sh
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,6 @@ The compose files under the `taf` subfolder are used for the automated TAF tests
- `make get-token`
For secure mode only. Runs commands via docker to generate a new API Gateway token.

- `make get-consul-acl-token`
For secure mode only. Runs commands via docker to retrieve a Consul Access token.

### Additional compose files

- **docker-compose-portainer.yml**
Expand Down
27 changes: 10 additions & 17 deletions compose-builder/.env
Original file line number Diff line number Diff line change
Expand Up @@ -42,26 +42,9 @@ DEVICE_UART_VERSION=latest
DEVICE_ONVIFCAM_VERSION=latest
DEVICE_USBCAM_VERSION=latest
DEVICE_S7_VERSION=latest
CP_FLAGS='-cp=keeper.http://edgex-core-keeper:59890'
DATABASE_HOST=edgex-postgres
DATABASE_TYPE=postgres
DATABASE_PORT=5432
MESSAGEBUS_HOST=edgex-mqtt-broker
MESSAGEBUS_SECRETNAME=message-bus
MESSAGEBUS_AUTHMODE=usernamepassword
MESSAGEBUS_PORT=1883
MESSAGEBUS_PROTOCOL=tcp
MESSAGEBUS_TYPE=mqtt
WRITABLE_INSECURESECRETS_DB_SECRETNAME=postgres
WRITABLE_INSECURESECRETS_DB_SECRETDATA_USERNAME=postgres
WRITABLE_INSECURESECRETS_DB_SECRETDATA_PASSWORD=postgres

# Lock on OpenBao 2.0 (last MPL-2.0 version)
BAO_VERSION=2.0
# Lock on Consul 1.16 (last MPL-2.0 version)
CONSUL_VERSION=1.16
# Lock on Redis 7.0 until EdgeX 4.0
REDIS_VERSION=7.0-alpine
POSTGRES_VERSION=16.3-alpine3.20
KUIPER_VERSION=v1.14.0-alpha.2
MOSQUITTO_VERSION=2.0
Expand All @@ -70,3 +53,13 @@ NATS_VERSION=2.9-alpine
NGINX_VERSION=1.25-alpine-slim
EDGEX_USER=2002
EDGEX_GROUP=2001

CP_FLAGS='-cp=keeper.http://edgex-core-keeper:59890'
DATABASE_HOST=edgex-postgres
DATABASE_PORT=5432
MESSAGEBUS_HOST=edgex-mqtt-broker
MESSAGEBUS_SECRETNAME=message-bus
MESSAGEBUS_AUTHMODE=usernamepassword
MESSAGEBUS_PORT=1883
MESSAGEBUS_PROTOCOL=tcp
MESSAGEBUS_TYPE=mqtt
150 changes: 57 additions & 93 deletions compose-builder/Makefile

Large diffs are not rendered by default.

11 changes: 0 additions & 11 deletions compose-builder/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ This folder contains the following compose files:
Base non-secure mode compose file with PostgreSQL as database. Contains all the services that run in the non-secure configuration, including the UI.
- **add-security.yml**<br/>
Security **extending** compose file. Adds the additional security services and configuration of services so that all the services are running in the secure configuration.
- **add-secure-redis-messagebus.yml**<br/>
Secure Redis MessageBus **extending** compose file. Adds the additional security configuration for when Redis is used as MessageBus in secure mode so Kuiper can connect to the secure MessageBus.
- **add-delayed-start-services.yml**<br/>
Secure delayed start services **extending** compose file. Adds additional delayed start services based on spire/spiffe implementation to provide the secret store token on the runtime secure configuration.
- **add-device-bacnet-ip.yml**<br/>
Expand Down Expand Up @@ -387,13 +385,6 @@ Options:
KEY_INPUT_FILE=<full_path_to_key_file>: the full file name path to your own key file, this is required
```

#### Get-consul-acl-token

```
get-consul-acl-token
Retrieves the Consul ACL token
```

#### Build Canned
```
build-canned
Expand Down Expand Up @@ -458,8 +449,6 @@ Options:
as-record-replay: Generates compose file with App Record & Replay included
asc-ex-mqtt: Generates compose file with App Service External MQTT Trigger included
mqtt-broker: Generates compose file with a MQTT Broker service included
mqtt-bus: Generates compose file with services configure for MQTT Message Bus
The MQTT Broker service is also included.
nanomq: ** Experimental **
Generates compose file with NonoMQ MQTT broker when mqtt-broker or mqtt-bus are specified
Not valid in secure mode when uses with mqtt-bus
Expand Down
4 changes: 0 additions & 4 deletions compose-builder/add-postgres.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
# *
# *******************************************************************************/

# TODO: Move the content of this Docker Compose file to add-security.yml when the redis database support is removed

volumes:
db-data:

Expand All @@ -38,5 +36,3 @@ services:
- no-new-privileges:true
tmpfs:
- /run


36 changes: 0 additions & 36 deletions compose-builder/add-redis-messagebus.yml

This file was deleted.

34 changes: 0 additions & 34 deletions compose-builder/add-redis.yml

This file was deleted.

2 changes: 0 additions & 2 deletions compose-builder/add-secure-postgres.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
# *
# *******************************************************************************/

# TODO: Move the content of this Docker Compose file to add-security.yml when the redis database support is removed

volumes:
postgres-data:

Expand Down
45 changes: 0 additions & 45 deletions compose-builder/add-secure-redis-db.yml

This file was deleted.

44 changes: 0 additions & 44 deletions compose-builder/add-secure-redis-messagebus.yml

This file was deleted.

6 changes: 2 additions & 4 deletions compose-builder/add-security.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ services:
EDGEX_GROUP: ${EDGEX_GROUP}
# Uncomment and modify the following "EDGEX_ADD_SECRETSTORE_TOKENS" to add the additional secret store tokens on the fly
# the secret store token is required if you have added registry acl roles from env "EDGEX_ADD_REGISTRY_ACL_ROLES"
# in service "consul".
#EDGEX_ADD_SECRETSTORE_TOKENS: app-sample,app-rules-engine-redis, app-rules-engine-mqtt, app-push-to-core
# in registry service.
#EDGEX_ADD_SECRETSTORE_TOKENS: app-sample,app-rules-engine, app-push-to-core
read_only: true
restart: always
networks:
Expand Down Expand Up @@ -130,7 +130,6 @@ services:
depends_on:
- security-bootstrapper
- security-secretstore-setup
- database

support-notifications:
env_file:
Expand Down Expand Up @@ -211,7 +210,6 @@ services:
- security-secretstore-setup

# this is to make sure the service is started after security-bootstrapper process is done
# because it needs to await Consul roles to be created
app-rules-engine:
entrypoint: ["/edgex-init/ready_to_run_wait_install.sh"]
command: "/app-service-configurable --registry ${CP_FLAGS}"
Expand Down
11 changes: 4 additions & 7 deletions compose-builder/docker-compose-base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,24 +42,21 @@ services:
env_file:
- common-non-security.env
environment:
DATABASE_HOST: ${DATABASE_HOST}
DATABASE_TYPE: ${DATABASE_TYPE}
DATABASE_PORT: ${DATABASE_PORT}
MESSAGEBUS_HOST: ${MESSAGEBUS_HOST}
MESSAGEBUS_AUTHMODE: ${MESSAGEBUS_AUTHMODE}
MESSAGEBUS_SECRETNAME: ${MESSAGEBUS_SECRETNAME}
MESSAGEBUS_PORT: ${MESSAGEBUS_PORT}
MESSAGEBUS_PROTOCOL: ${MESSAGEBUS_PROTOCOL}
MESSAGEBUS_TYPE: ${MESSAGEBUS_TYPE}
WRITABLE_INSECURESECRETS_DB_SECRETNAME: ${WRITABLE_INSECURESECRETS_DB_SECRETNAME}
WRITABLE_INSECURESECRETS_DB_SECRETDATA_USERNAME: ${WRITABLE_INSECURESECRETS_DB_SECRETDATA_USERNAME}
WRITABLE_INSECURESECRETS_DB_SECRETDATA_PASSWORD: ${WRITABLE_INSECURESECRETS_DB_SECRETDATA_PASSWORD}
SERVICE_HOST: edgex-core-keeper
DATABASE_HOST: ${DATABASE_HOST}
security_opt:
- no-new-privileges:true
volumes:
# use host timezone
- /etc/localtime:/etc/localtime:ro
depends_on:
- database

support-notifications:
image: ${CORE_EDGEX_REPOSITORY}/support-notifications${ARCH}:${CORE_EDGEX_VERSION}
Expand Down Expand Up @@ -205,7 +202,7 @@ services:
- common-non-security.env
environment:
ALL_SERVICES_REGISTRY_HOST: edgex-core-keeper
ALL_SERVICES_DATABASE_HOST: edgex-postgres
ALL_SERVICES_DATABASE_HOST: ${DATABASE_HOST}
ALL_SERVICES_MESSAGEBUS_HOST: ${MESSAGEBUS_HOST}
APP_SERVICES_CLIENTS_CORE_METADATA_HOST: edgex-core-metadata
DEVICE_SERVICES_CLIENTS_CORE_METADATA_HOST: edgex-core-metadata
Expand Down
20 changes: 0 additions & 20 deletions compose-builder/get-consul-acl-token.sh

This file was deleted.

Loading

0 comments on commit 2bccd51

Please sign in to comment.