Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add go-winio to attribution (new SPIFFE dependency) #286

Merged
merged 1 commit into from
May 31, 2022

Conversation

vli11
Copy link
Contributor

@vli11 vli11 commented May 27, 2022

Signed-off-by: Valina Li [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-virtual-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

Codecov Report

Merging #286 (a7b7b7f) into main (9b27552) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage   58.60%   58.60%           
=======================================
  Files          13       13           
  Lines         860      860           
=======================================
  Hits          504      504           
  Misses        312      312           
  Partials       44       44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b27552...a7b7b7f. Read the comment docs.

@lenny-goodell lenny-goodell merged commit 9cab873 into edgexfoundry:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants