feat: update profile cache to reflect new profile model #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudxxx8
requested changes
Apr 6, 2021
cloudxxx8
requested changes
Apr 6, 2021
added 2 commits
April 6, 2021 16:43
device profile model has been updated in edgexfoundry/go-mod-core-contracts#540 update the profile cache for consistent and better usage. Signed-off-by: Chris Hung <[email protected]>
Signed-off-by: Chris Hung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-c/blob/master/.github/CONTRIBUTING.md
What is the current behavior?
profile cache design and implementation is not aligned with latest profile model: edgexfoundry/go-mod-core-contracts#540
Issue Number: fix #854
What is the new behavior?
update profile cache. Also status code 405 can now be correctly returned by device command while trying to read(write) a write-only(read-only) device command.
Does this PR introduce a breaking change?
DeviceService.ResourceOperationmethod has been updated toDeviceService.DeviceCommandNew Imports
Specific Instructions
Other information