Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow reading value to be null #1633

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

weichou1229
Copy link
Member

Allow reading value to be null

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Test with device simple.

New Dependency Instructions (If applicable)

Allow reading value to be null

Signed-off-by: bruce <[email protected]>
@weichou1229 weichou1229 requested a review from cloudxxx8 October 4, 2024 08:12
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 32.65%. Comparing base (1b8f5c3) to head (888d014).

Files with missing lines Patch % Lines
pkg/models/commandvalue.go 0.00% 3 Missing and 1 partial ⚠️
internal/transformer/transform.go 0.00% 1 Missing and 1 partial ⚠️
internal/transformer/transformresult.go 0.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1633      +/-   ##
==========================================
- Coverage   32.71%   32.65%   -0.06%     
==========================================
  Files          48       48              
  Lines        4738     4746       +8     
==========================================
  Hits         1550     1550              
- Misses       3052     3057       +5     
- Partials      136      139       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudxxx8 cloudxxx8 merged commit 9dc1e0e into edgexfoundry:main Oct 4, 2024
3 checks passed
@weichou1229 weichou1229 deleted the issue-931 branch October 7, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants