Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Publish System Events for device discovery and profile scan progress #1616

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

jinlinGuan
Copy link
Contributor

close #1611

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@jinlinGuan jinlinGuan requested a review from cloudxxx8 August 27, 2024 01:57
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 45.50%. Comparing base (a573d62) to head (3e6ea37).

Files Patch % Lines
internal/controller/http/discovery.go 0.00% 19 Missing ⚠️
pkg/service/service.go 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1616      +/-   ##
==========================================
- Coverage   45.70%   45.50%   -0.21%     
==========================================
  Files          30       30              
  Lines        2958     2971      +13     
==========================================
  Hits         1352     1352              
- Misses       1501     1514      +13     
  Partials      105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

example/driver/simpledriver.go Outdated Show resolved Hide resolved
example/driver/simpledriver.go Outdated Show resolved Hide resolved
pkg/interfaces/service.go Show resolved Hide resolved
internal/utils/notify.go Outdated Show resolved Hide resolved
internal/container/deviceservice.go Outdated Show resolved Hide resolved
internal/controller/http/discovery.go Show resolved Hide resolved
internal/controller/http/discovery.go Outdated Show resolved Hide resolved
internal/utils/notify.go Outdated Show resolved Hide resolved
openapi/v3/device-sdk.yaml Show resolved Hide resolved
pkg/models/notify.go Show resolved Hide resolved
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 6fbfd52 into edgexfoundry:main Aug 27, 2024
3 checks passed
@jinlinGuan jinlinGuan deleted the issue-1611 branch August 27, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send out System Event for the device discovery and profile scan progress
3 participants