Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Use bool types for command parameters to be more consistent #1279

Merged
merged 1 commit into from
Jan 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/controller/http/command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ func TestRestController_GetCommand_ReturnEvent(t *testing.T) {
require.NoError(t, err)

query := req.URL.Query()
query.Add("ds-returnevent", "no")
query.Add("ds-returnevent", common.ValueFalse)
req.URL.RawQuery = query.Encode()
// Act
recorder := httptest.NewRecorder()
Expand Down
20 changes: 10 additions & 10 deletions openapi/v2/device-sdk.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1095,21 +1095,21 @@ paths:
schema:
type: string
enum:
- yes
- no
default: no
example: yes
description: "If set to yes, a successful GET will result in an event being pushed to the EdgeX system"
- true
- false
default: false
example: true
description: "If set to true, a successful GET will result in an event being pushed to the EdgeX system"
- in: query
name: ds-returnevent
schema:
type: string
enum:
- yes
- no
default: yes
example: no
description: "If set to no, there will be no Event returned in the http response"
- true
- false
default: true
example: false
description: "If set to false, there will be no Event returned in the http response"
responses:
'200':
description: String as returned by the device/sensor through the device service.
Expand Down