Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Rework code for refactored MessageBus Configuration #1273

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Jan 10, 2023

BREAKING CHANGE: MessageQueue renamed to MessageBus and fields changed. See v3 Migration guide.

This PR dependent on edgexfoundry/go-mod-bootstrap#410

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    TBD

Testing Instructions

Run non-secure Edgex Stack with device virtual and stop all core/support services.
Build example locally
Run example locally with DEBUG log level
Verify example bootstraps properly and connects to the MessageBus
Verify example pushing events events.

New Dependency Instructions (If applicable)

BREAKING CHANGE: MessageQueue renamed to MessageBus and fields changed. See v3 Migration guide.

Signed-off-by: Leonard Goodell <[email protected]>
@lenny-goodell lenny-goodell requested a review from ejlee3 January 11, 2023 17:12
Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lenny-goodell lenny-goodell merged commit 8541928 into edgexfoundry:main Jan 11, 2023
@lenny-goodell lenny-goodell deleted the mb-config branch January 11, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants