Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support object value type in Set Command #1038

Merged
merged 2 commits into from
Oct 20, 2021
Merged

feat: Support object value type in Set Command #1038

merged 2 commits into from
Oct 20, 2021

Conversation

weichou1229
Copy link
Member

@weichou1229 weichou1229 commented Oct 19, 2021

Make the Set Command payload to allow object value type parameters

Closes #1037

Signed-off-by: bruce [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    feat(command): Support object value type in Set Command edgex-go#3762

Testing Instructions

  1. Clone the repo or pull the branch from:
  2. Run core-service and simple-device with specified core-contracts branch
  3. Execute Set command
  4. Execute Read command to inspect the result
  5. Query event API to inspect the reading result

New Dependency Instructions (If applicable)

Make the Set Command payload to allow object value type parameters

Closes #1037

Signed-off-by: bruce <[email protected]>
@weichou1229
Copy link
Member Author

This PR should hold until edgexfoundry/go-mod-core-contracts#676 merged

@codecov-commenter
Copy link

Codecov Report

Merging #1038 (e8b3470) into main (2ab93c4) will increase coverage by 0.05%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
+ Coverage   40.73%   40.79%   +0.05%     
==========================================
  Files          29       29              
  Lines        3022     3025       +3     
==========================================
+ Hits         1231     1234       +3     
  Misses       1696     1696              
  Partials       95       95              
Impacted Files Coverage Δ
internal/controller/http/command.go 0.00% <0.00%> (ø)
internal/application/command.go 27.89% <85.71%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab93c4...e8b3470. Read the comment docs.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 1be87f1 into edgexfoundry:main Oct 20, 2021
@weichou1229 weichou1229 deleted the issue-1037 branch October 21, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support object value type in Set Command
3 participants