Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: updated makefile for security hardening #78

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

marcpfuller
Copy link
Contributor

Signed-off-by: Marc-Philippe Fuller [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-rfid-llrp-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)N/A
  • I have opened a PR for the related docs change (if not, why?)N/A

Testing Instructions

make build

New Dependency Instructions (If applicable)

N/A

@lenny-goodell lenny-goodell requested a review from bnevis-i April 28, 2022 21:02
@marcpfuller marcpfuller changed the title fix: updated makefile for security hardening security: updated makefile for security hardening Apr 28, 2022
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #78 (260f534) into main (ae184f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   41.08%   41.08%           
=======================================
  Files          21       21           
  Lines        9016     9016           
=======================================
  Hits         3704     3704           
- Misses       4142     4143    +1     
+ Partials     1170     1169    -1     
Impacted Files Coverage Δ
internal/llrp/reader.go 40.13% <0.00%> (ø)
internal/retry/retry.go 93.12% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae184f2...260f534. Read the comment docs.

@lenny-goodell lenny-goodell merged commit fa56b1b into edgexfoundry:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants