Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps)!: bump sdk to 3.0.0-dev.54 #272

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

weichou1229
Copy link
Member

@weichou1229 weichou1229 commented Mar 21, 2023

BREAKING CHANGE: profile resource properties can use numeric data type for mask,shift,base,scale,offset.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-rest-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) not impact
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) not impact

Testing Instructions

Run device service and test API

New Dependency Instructions (If applicable)

@cloudxxx8 cloudxxx8 requested a review from lenny-goodell March 21, 2023 04:25
@weichou1229 weichou1229 force-pushed the bump-sdk branch 2 times, most recently from e64fc68 to 53d5713 Compare March 21, 2023 04:32
@weichou1229 weichou1229 changed the title refactor!: Change configuration file format to YAML build(deps): bump sdk to 3.0.0-dev.54 Mar 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Merging #272 (b7caf4f) into main (2ded8c8) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   32.95%   32.86%   -0.10%     
==========================================
  Files           2        2              
  Lines         352      353       +1     
==========================================
  Hits          116      116              
- Misses        223      224       +1     
  Partials       13       13              
Impacted Files Coverage Δ
driver/restdriver.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cloudxxx8 cloudxxx8 removed the request for review from lenny-goodell March 21, 2023 04:39
BREAKING CHANGE: profile resource properties can use numeric data type for mask,shift,base,scale,offset.

Signed-off-by: bruce <[email protected]>
@weichou1229 weichou1229 changed the title build(deps): bump sdk to 3.0.0-dev.54 build(deps)!: bump sdk to 3.0.0-dev.54 Mar 21, 2023
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit e28169b into edgexfoundry:main Mar 21, 2023
@weichou1229 weichou1229 deleted the bump-sdk branch March 21, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants