Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(snap): Move usage instructions to docs #342

Merged
merged 3 commits into from
May 6, 2022

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented May 5, 2022

Usage instructions are being moved to docs; see edgexfoundry/edgex-docs#751.
The snap/README has been updated to include development docs only.

Depends on:

Signed-off-by: Mengyi [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-modbus-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

Codecov Report

Merging #342 (1f3c8e5) into main (0336c9d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   41.16%   41.16%           
=======================================
  Files           6        6           
  Lines         566      566           
=======================================
  Hits          233      233           
  Misses        293      293           
  Partials       40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0336c9d...1f3c8e5. Read the comment docs.

Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farshidtz farshidtz marked this pull request as ready for review May 6, 2022 13:11
@farshidtz farshidtz merged commit d7023bc into edgexfoundry:main May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants