This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
feat(security): Add redis config file related envs #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-wang-intel
added
2-medium
jim-wang-intel
requested review from
beaufrusetta,
cloudxxx8,
bnevis-i,
cherrycl and
lenny-goodell
bnevis-i
reviewed
Feb 3, 2021
There was a problem hiding this comment.
Looks good, approval pending response to @bnevis-i comment.
lenny-goodell
previously approved these changes
Feb 3, 2021
New env added for redis' conf files related Closes: edgexfoundry#402 Signed-off-by: Jim Wang <[email protected]>
Address Bryon's comment about more standard temp. file system /run Signed-off-by: Jim Wang <[email protected]>
jim-wang-intel
dismissed stale reviews from lenny-goodell and bnevis-i
via
f3ce08d
jim-wang-intel
force-pushed
the
add-redis-conf-envs-402
branch
from
8a05af0 to
f3ce08d
Compare
Added env changes from make build Signed-off-by: Jim Wang <[email protected]>
jim-wang-intel
force-pushed
the
add-redis-conf-envs-402
branch
from
f3ce08d to
ee62a58
Compare
|
recheck |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New env added for redis' conf files related
Closes: #402
Signed-off-by: Jim Wang [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/developer-scripts/blob/master/.github/Contributing.md.
What is the current behavior?
No redis conf file used in the current behavior
Issue Number: #402
What is the new behavior?
Redis conf envs added
Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
This PR depends on edgexfoundry/edgex-go#3115 and thus should be merged after that PR is merged.
Other information