This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
feat(security): Add upload-tls-cert makefile target #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new makefile target for compose-builder: upload-tls-cert This can be used to setup a bring-your-own (BYO) TLS certificate for Kong proxy server in an Edgex docker-compose stack Closes: edgexfoundry/edgex-go#1926, edgexfoundry/edgex-go#1922 Signed-off-by: Jim Wang <[email protected]>
jim-wang-intel
added
enhancement
lenny-goodell
suggested changes
Dec 10, 2020
Address PR feedback on modifying the usage text Signed-off-by: Jim Wang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new makefile target for compose-builder: upload-tls-cert
This can be used to setup a bring-your-own (BYO) TLS certificate for Kong proxy server in an Edgex docker-compose stack
Closes: edgexfoundry/edgex-go#1926, edgexfoundry/edgex-go#1922
Signed-off-by: Jim Wang [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/developer-scripts/blob/master/.github/Contributing.md.
What is the current behavior?
Currently, there is no make target to upload Kong's TLS certificate.
Issue Number: edgexfoundry/edgex-go#1926
What is the new behavior?
New make file target
upload-tls-certis added.Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information
To test this locally, do the following steps:
edgex-go, and create the local version of docker images bymake dockerdeveloper-scriptsrepo, git clone this PR, and change the directory tocompose-buildermake run devKong TLS certificate uploaded.