Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app-functions-sdk-go backwards compatibility, fixes #95 #96

Merged
merged 1 commit into from
Jul 16, 2020
Merged

fix: app-functions-sdk-go backwards compatibility, fixes #95 #96

merged 1 commit into from
Jul 16, 2020

Conversation

charles-knox-intel
Copy link
Contributor

Signed-off-by: charles-knox-intel [email protected]

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently the dependency version in go.mod is out of date and doesn't include the latest fix from edgexfoundry/app-functions-sdk-go#409. Additionally, the sample configuration.toml files need to be updated to properly document the fixed behaviors from that PR.

Issue Number: #95

What is the new behavior?

Dependency updated, and comments updated

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

Just an updated version for app-functions-sdk-go

Are there any specific instructions or things that should be known prior to reviewing?

No

Other information

@charles-knox-intel charles-knox-intel marked this pull request as ready for review July 16, 2020 00:38
@rsdmike rsdmike merged commit 7083d63 into edgexfoundry:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants