refactor: Update for new service key names and overrides for hyphen to underscore #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 13, 2021
jim-wang-intel
previously approved these changes
May 13, 2021
lenny-goodell
force-pushed
the
service-keys
branch
from
9e3e658 to
a202714
Compare
…o underscore closes edgexfoundry#252 closes edgexfoundry#235 BREAKING CHANGE: Service key names used in configuration have changed. Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
service-keys
branch
from
a202714 to
d286ff0
Compare
jim-wang-intel
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on edgexfoundry/go-mod-core-contracts#613
Dependent on edgexfoundry/go-mod-bootstrap#216
Dependent on edgexfoundry/app-functions-sdk-go/pull/838
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
Service key constants have the edgex- prefix
Issue Number: #252 & #235
What is the new behavior?
Service key constants no longer have the edgex- prefix
Hyphen in Overrides are converted to underscore
Does this PR introduce a breaking change?
BREAKING CHANGE: Service key names used in configuration have changed.
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information