Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rework code and profiles for refactored SDK #214

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Mar 16, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Uses previous non-refactored SDK

Issue Number: #213

What is the new behavior?

Uses previous refactored SDK
Profiles updated for rename of SetOutputData to SetResponseData

Does this PR introduce a breaking change?

  • Yes
  • No

BREAKING CHANGE: Pipeline configuration has changed. SetOutputData renamed to SetResponseData

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

jim-wang-intel
jim-wang-intel previously approved these changes Mar 16, 2021
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AlexCuse
AlexCuse previously approved these changes Mar 18, 2021
@lenny-goodell lenny-goodell marked this pull request as ready for review March 18, 2021 15:01
@lenny-goodell
Copy link
Member Author

recheck

1 similar comment
@lenny-goodell
Copy link
Member Author

recheck

@lenny-goodell lenny-goodell marked this pull request as draft March 18, 2021 15:59
@lenny-goodell lenny-goodell dismissed stale reviews from AlexCuse and jim-wang-intel via 56d1327 March 18, 2021 19:37
@lenny-goodell lenny-goodell marked this pull request as ready for review March 18, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASC: Update code and profiles for the major SDK refactoring changes
3 participants