fix(snap): fix README's security-secret-store doc #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
previously approved these changes
Mar 2, 2021
|
recheck |
2 similar comments
|
recheck |
|
recheck |
The snap's README incorrectly stated that security-secret-store could be set to 'false' to disable secret store usage. The correct value is 'off'. Signed-off-by: Tony Espy <[email protected]>
tonyespy
force-pushed
the
snap-master-fix-readme-secret-store
branch
from
b210793 to
a333377
Compare
|
Just re-based and force pushed... |
lenny-goodell
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snap's
READMEincorrectly stated that security-secret-store could be set tofalseto disable secret store usage. The correct value isoff.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
NA
Issue Number: NA
What is the new behavior?
NA
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
No
Are there any specific instructions or things that should be known prior to reviewing?
No
Other information