Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement V2 Ping endpoint and V2 layers #433

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

eno-intel
Copy link
Contributor

fixes: #432

Signed-off-by: Enobong Udoko [email protected]

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number:
#432

What is the new behavior?

add the V2 ping endpoint and controller/http layer

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

No

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@eno-intel eno-intel marked this pull request as draft July 31, 2020 21:56
@eno-intel eno-intel marked this pull request as ready for review July 31, 2020 21:56
@eno-intel eno-intel marked this pull request as draft July 31, 2020 21:57
internal/v2/controller/http/controller.go Show resolved Hide resolved
internal/v2/controller/http/controller_test.go Outdated Show resolved Hide resolved
internal/v2/controller/http/controller.go Outdated Show resolved Hide resolved
internal/v2/controller/http/controller.go Outdated Show resolved Hide resolved
internal/v2/controller/http/controller.go Outdated Show resolved Hide resolved
internal/v2/controller/http/controller_test.go Outdated Show resolved Hide resolved
internal/v2/routes.go Outdated Show resolved Hide resolved
@eno-intel eno-intel marked this pull request as ready for review August 4, 2020 19:28
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 1cb68c1 into edgexfoundry:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement V2 Ping endpoint and V2 layers
4 participants