feat: configurable ListenAndServe address, fixes #405 #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@charles-knox-intel , please use |
charles-knox-intel
changed the title
Signed-off-by: charles-knox-intel <[email protected]>
|
@lenny-intel Thanks for the feedback, will do in the future! Commit has been updated |
12 tasks
12 tasks
lenny-goodell
pushed a commit
that referenced
this pull request
Jul 15, 2020
Signed-off-by: charles-knox-intel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: charles-knox-intel [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
ListenAndServeinternal API calls to start the app functions SDK web server currently only listen on:<port>, which prevents developers from using the SDK in various environments that may not allow for binding on the0.0.0.0interface.Issue Number: #405
What is the new behavior?
A new configurable option called
ServerBindAddrhas been added, similar to edgexfoundry/go-mod-bootstrap#84 and edgexfoundry/go-mod-bootstrap#83. IfServerBindAddris not specified,app-functions-sdk-gowill instead use theHostvalue from the service's configuration. If neither are defined, then the value will be:<port>, which is how it was previously, resulting inListenAndServebeing called on the0.0.0.0interface.Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
No
Are there any specific instructions or things that should be known prior to reviewing?
No
Other information