Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated examples for changes to Device Virtual #100

Merged
merged 3 commits into from
Jun 7, 2019

Conversation

lenny-goodell
Copy link
Member

This PR addresses #97 .

Updates for device name changed to Random-Float-Device

Updated advanced example ReadMe to change Device Virtual device profile to use expected floatEncoding and to set min/max values

@lenny-goodell lenny-goodell requested a review from rsdmike June 7, 2019 21:35
5. Run Device Virtual service
5. Run **Device Virtual** service

This example expects the float encoding for all random floats to be `Base64` and needs to restrict the range of values that are generated so they are easy to read. By default the device-virtual is using `Base64` for Float32 & `eNotation` for Float64 and doesn't see and range limits. Below are instructions on how to change the configuration to meet these needs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"and doesn't see and range limits" -- wut?

"change the configuration to meet these needs." -- remove double space

@rsdmike rsdmike self-requested a review June 7, 2019 22:53
@lenny-goodell lenny-goodell merged commit 942285e into edgexfoundry:master Jun 7, 2019
@lenny-goodell lenny-goodell deleted the Examples branch June 7, 2019 22:54
lenny-goodell added a commit that referenced this pull request Jul 24, 2020
…416)

Core Data is now using the semver tag for it's `dev` version.

closes #100

Signed-off-by: lenny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants