refactor(triggers): Normalize Orchestration #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexCuse
force-pushed
the
trigger-refactoring
branch
from
fef4bc0 to
78af7e0
Compare
Closed
Codecov Report
@@ Coverage Diff @@
## main #967 +/- ##
==========================================
+ Coverage 68.17% 68.96% +0.78%
==========================================
Files 35 36 +1
Lines 2734 2845 +111
==========================================
+ Hits 1864 1962 +98
- Misses 762 775 +13
Partials 108 108
Continue to review full report at Codecov.
|
AlexCuse
force-pushed
the
trigger-refactoring
branch
from
78af7e0 to
9ebde02
Compare
AlexCuse
force-pushed
the
trigger-refactoring
branch
2 times, most recently
from
9d857f3 to
8388dad
Compare
|
@AlexCuse , I like the idea of this but think it needs to wait until Kamakura. For Jakarta (LTS) we want to avoid these kind of refactoring to stable code. Also too close to code freeze to make these changes. THX! |
|
I'll see what I can do to fix the custom trigger multi-pipeline issue without it @lenny-intel |
AlexCuse
force-pushed
the
trigger-refactoring
branch
2 times, most recently
from
199ee09 to
1a27d5b
Compare
AlexCuse
force-pushed
the
trigger-refactoring
branch
from
1a27d5b to
4fb1cb3
Compare
AlexCuse
force-pushed
the
trigger-refactoring
branch
from
4fb1cb3 to
b66893a
Compare
lenny-goodell
requested changes
Dec 28, 2021
Share functionality between custom and built-in triggers, expanding testability of those built-in. fixes edgexfoundry#960 Signed-off-by: Alex Ullrich <[email protected]>
AlexCuse
force-pushed
the
trigger-refactoring
branch
from
b66893a to
2d6c7c3
Compare
lenny-goodell
requested changes
Dec 29, 2021
FelixTing
pushed a commit
to FelixTing/app-functions-sdk-go
that referenced
this pull request
Mar 3, 2022
Share functionality between custom and built-in triggers, expanding testability of those built-in. fixes edgexfoundry#960 Signed-off-by: Alex Ullrich <[email protected]> Co-authored-by: Lenny Goodell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share functionality between custom and built-in triggers, expanding
testability of those built-in.
fixes #960
Signed-off-by: Alex Ullrich [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)need to look into running TAF locally have only tested with a couple services I had handy.
looking for comment before updating docs
Testing Instructions
New Dependency Instructions (If applicable)