Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support processing response data in custom trigger multi-pipeline #958

Closed
jlikeme opened this issue Sep 28, 2021 · 6 comments · Fixed by #967 or #989
Closed

Support processing response data in custom trigger multi-pipeline #958

jlikeme opened this issue Sep 28, 2021 · 6 comments · Fixed by #967 or #989
Labels
hold Intended for PRs we want to flag for ongoing review
Milestone

Comments

@jlikeme
Copy link

jlikeme commented Sep 28, 2021

Support processing response data in custom trigger multi-pipeline

@lenny-goodell
Copy link
Member

@gao270615179 , please provide more detail for what you are asking for here. An example of your use case always helps.

@lenny-goodell lenny-goodell added the hold Intended for PRs we want to flag for ongoing review label Oct 5, 2021
@AlexCuse
Copy link
Contributor

AlexCuse commented Oct 12, 2021

@gao270615179 this needed some refactoring as the multi-pipeline stuff represented a big shift for the custom triggers. This was addressed as part of #967 (WIP) via a new MessageReceived method. The method takes an additional per-pipeline response handler. Would love to know if this would work for what you have in mind.

@AlexCuse AlexCuse linked a pull request Oct 12, 2021 that will close this issue
5 tasks
AlexCuse added a commit to AlexCuse/app-functions-sdk-go that referenced this issue Oct 12, 2021
Share functionality between custom and built-in triggers, expanding
testability of those built-in.  Also adds support for handling
per-pipeline response data.

fixes edgexfoundry#960
fixes edgexfoundry#958

Signed-off-by: Alex Ullrich <[email protected]>
AlexCuse added a commit to AlexCuse/app-functions-sdk-go that referenced this issue Oct 12, 2021
Share functionality between custom and built-in triggers, expanding
testability of those built-in.  Also adds support for handling
per-pipeline response data to custom triggers.

fixes edgexfoundry#960
fixes edgexfoundry#958

Signed-off-by: Alex Ullrich <[email protected]>
@jlikeme
Copy link
Author

jlikeme commented Oct 18, 2021

@AlexCuse This is what I need. I will test this commit. Thanks!

@lenny-goodell lenny-goodell added this to the Kamakura milestone Oct 26, 2021
@lenny-goodell
Copy link
Member

Moved issue to Ice Box for now as the PR is on hold and will be addressed in the Kamakura dev cycle

AlexCuse added a commit to AlexCuse/app-functions-sdk-go that referenced this issue Oct 29, 2021
Enable passing a handler to process pipeline responses when invoking
runtime from a custom trigger.

fixes edgexfoundry#958

Signed-off-by: Alex Ullrich <[email protected]>
AlexCuse added a commit to AlexCuse/app-functions-sdk-go that referenced this issue Oct 29, 2021
Enable passing a handler to process pipeline responses when invoking
runtime from a custom trigger.

fixes edgexfoundry#958

Signed-off-by: Alex Ullrich <[email protected]>
@AlexCuse
Copy link
Contributor

@gao270615179 did you ever test using the branch above - we are going to try to get the custom
trigger piece of that into Jakarta and save the built in trigger refactoring for the next release cycle, have a new PR up now.

AlexCuse added a commit to AlexCuse/app-functions-sdk-go that referenced this issue Oct 30, 2021
Enable passing a handler to process pipeline responses when invoking
runtime from a custom trigger.

fixes edgexfoundry#958

Signed-off-by: Alex Ullrich <[email protected]>
AlexCuse added a commit to AlexCuse/app-functions-sdk-go that referenced this issue Nov 1, 2021
Enable passing a handler to process pipeline responses when invoking
runtime from a custom trigger.

fixes edgexfoundry#958

Signed-off-by: Alex Ullrich <[email protected]>
AlexCuse added a commit to AlexCuse/app-functions-sdk-go that referenced this issue Nov 1, 2021
Enable passing a handler to process pipeline responses when invoking
runtime from a custom trigger.

fixes edgexfoundry#958

Signed-off-by: Alex Ullrich <[email protected]>
@jlikeme
Copy link
Author

jlikeme commented Nov 2, 2021

@AlexCuse Sorry, I'm late for testing. I have test the commit AlexCuse@e0d616d. It's useful for me.

AlexCuse added a commit to AlexCuse/app-functions-sdk-go that referenced this issue Nov 2, 2021
Enable passing a handler to process pipeline responses when invoking
runtime from a custom trigger.

fixes edgexfoundry#958

Signed-off-by: Alex Ullrich <[email protected]>
lenny-goodell pushed a commit that referenced this issue Nov 2, 2021
…#989)

Enable passing a handler to process pipeline responses when invoking
runtime from a custom trigger.

fixes #958

Signed-off-by: Alex Ullrich <[email protected]>

Co-authored-by: Lenny Goodell <[email protected]>
AlexCuse added a commit to AlexCuse/app-functions-sdk-go that referenced this issue Nov 22, 2021
Share functionality between custom and built-in triggers, expanding
testability of those built-in.  Also adds support for handling
per-pipeline response data to custom triggers.

fixes edgexfoundry#960
fixes edgexfoundry#958

Signed-off-by: Alex Ullrich <[email protected]>
FelixTing pushed a commit to FelixTing/app-functions-sdk-go that referenced this issue Mar 3, 2022
…edgexfoundry#989)

Enable passing a handler to process pipeline responses when invoking
runtime from a custom trigger.

fixes edgexfoundry#958

Signed-off-by: Alex Ullrich <[email protected]>

Co-authored-by: Lenny Goodell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Intended for PRs we want to flag for ongoing review
Projects
None yet
3 participants