feat: Upgrade to new V2 Clients and refactor PushToCore #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
commented
Jun 8, 2021
| package transforms | ||
|
|
||
| import ( | ||
| "context" |
There was a problem hiding this comment.
Addition of this packaged caused name conflict to context variable in the test files, thus the rename of that variable to ctx
This was
linked to
issues
Jun 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
+ Coverage 63.08% 64.14% +1.05%
==========================================
Files 32 32
Lines 2102 2139 +37
==========================================
+ Hits 1326 1372 +46
+ Misses 683 674 -9
Partials 93 93
Continue to review full report at Codecov.
|
jim-wang-intel
requested changes
Jun 8, 2021
closes #370 & #721 BREAKING CHANGE: PushToCore signatures and required parameters have changed Signed-off-by: lenny <[email protected]>
Signed-off-by: lenny <[email protected]>
This was referenced Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Using V1 clients (except Command) and PushToCore is based on V1
Issue Number: #370 & #721
What is the new behavior?
Now using V2 clients and PushToCore has been refactored to conform to V2 API/DTOs
Does this PR introduce a breaking change?
BREAKING CHANGE: PushToCore signatures and required parameters have changed
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information