Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK: Update PushToCore for V2 Client changes #721

Closed
lenny-goodell opened this issue Feb 25, 2021 · 0 comments · Fixed by #882
Closed

SDK: Update PushToCore for V2 Client changes #721

lenny-goodell opened this issue Feb 25, 2021 · 0 comments · Fixed by #882
Labels
3-high priority denoting release-blocking issues app-services subsystem_affected for application services breaking change
Milestone
Ireland

Comments

@lenny-goodell
Copy link
Member

Following function parameter changes are needed
Rename ReadingName parameter to ResourceName
Add ProfileName parameter

Set the Event's SourceName to the value of the ResourceName
@lenny-goodell lenny-goodell mentioned this issue Feb 25, 2021
Closed
@lenny-goodell lenny-goodell added 3-high priority denoting release-blocking issues app-services subsystem_affected for application services breaking change labels Feb 25, 2021
@lenny-goodell lenny-goodell added this to the Ireland milestone Feb 25, 2021
@lenny-goodell lenny-goodell mentioned this issue Feb 25, 2021
Closed
@lenny-goodell lenny-goodell added the hold Intended for PRs we want to flag for ongoing review label Feb 26, 2021
@lenny-goodell lenny-goodell removed the hold Intended for PRs we want to flag for ongoing review label Jun 1, 2021
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Jun 8, 2021
feat: Upgrade to new V2 Clients and refactor PushToCore
98023f2 
closes #370 & #721

Signed-off-by: lenny <[email protected]>
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Jun 8, 2021
feat: Upgrade to new V2 Clients and refactor PushToCore
b33d96c 
closes #370 & #721

Signed-off-by: lenny <[email protected]>
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Jun 8, 2021
feat: Upgrade to new V2 Clients and refactor PushToCore
b9de9db 
closes #370 & #721

BREAKING CHANGE: PushToCore signatures and required parameters have changed

Signed-off-by: lenny <[email protected]>
@lenny-goodell lenny-goodell mentioned this issue Jun 8, 2021
Merged
12 tasks
@lenny-goodell lenny-goodell linked a pull request Jun 8, 2021 that will close this issue
feat: Upgrade to new V2 Clients and refactor PushToCore #882
Merged
12 tasks
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Jun 8, 2021
feat: Upgrade to new V2 Clients and refactor PushToCore
3dd966f 
closes #370 & #721

BREAKING CHANGE: PushToCore signatures and required parameters have changed

Signed-off-by: lenny <[email protected]>
lenny-goodell pushed a commit that referenced this issue Jun 9, 2021
feat: Upgrade to new V2 Clients and refactor PushToCore (#882)
69a9f95 
* feat: Upgrade to new V2 Clients and refactor PushToCore

closes #370 & #721

BREAKING CHANGE: PushToCore signatures and required parameters have changed

Signed-off-by: lenny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3-high priority denoting release-blocking issues app-services subsystem_affected for application services breaking change
Projects
None yet
Milestone
Ireland
Development

Successfully merging a pull request may close this issue.

feat: Upgrade to new V2 Clients and refactor PushToCore lenny-goodell/app-functions-sdk-go
1 participant
@lenny-goodell