refactor: Update for new service key names and overrides for hyphen to underscore #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 13, 2021
…o underscore closes edgexfoundry#801 closes edgexfoundry#837 BREAKING CHANGE: Service key names used in configuration have changed. Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
service-keys
branch
from
33664fc to
fd47f8c
Compare
Codecov Report
@@ Coverage Diff @@
## master #838 +/- ##
=======================================
Coverage 62.79% 62.79%
=======================================
Files 31 31
Lines 1981 1981
=======================================
Hits 1244 1244
Misses 647 647
Partials 90 90 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on edgexfoundry/go-mod-core-contracts#613
Dependent on edgexfoundry/go-mod-bootstrap#216
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
Service key constants have the edgex- prefix
Issue Number: #801 & #837
What is the new behavior?
Service key constants no longer have the edgex- prefix
Hyphen in Overrides are converted to underscore
Does this PR introduce a breaking change?
BREAKING CHANGE: Service key names used in configuration have changed.
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information