refactor: Rework SDK to use Interfaces and factory methods #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 16, 2021 10:26
Added mocks for interfaces for use is custom service unit tests. Refactored to make better use of the dependency injection container (dic) to propigate the common dependecies throught the layers General file clean up for items flag by IDE as non-standard code. closes #573 Signed-off-by: lenny <[email protected]>
Added mocks for interfaces for use is custom service unit tests. Refactored to make better use of the dependency injection container (dic) to propagate the common dependencies through out the layers General file clean up for items flag by IDE as non-standard code. closes #573 BREAKING CHANGE: App Services will require refactoring to use new interfaces and factory methods Signed-off-by: lenny <[email protected]>
lenny-goodell
commented
Mar 16, 2021
lenny-goodell
commented
Mar 16, 2021
jim-wang-intel
requested changes
Mar 16, 2021
AlexCuse
previously approved these changes
Mar 16, 2021
added 2 commits
March 18, 2021 11:04
Signed-off-by: lenny <[email protected]>
…el/app-functions-sdk-go into refactor-to-interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Code needed to be refactored to use interfaces and factory methods
Issue Number: #573
What is the new behavior?
Added mocks for interfaces for use is custom service unit tests.
Refactored to make better use of the dependency injection container (dic) to propagate the common dependencies through out the layers
General file clean up for items flag by IDE as non-standard code.
Renamed
OutputDatatoResponseDataThese ASC draft PR shows the impact of these changes
edgexfoundry/app-service-configurable#214
as well as the changes made to the template app service in this repo
Does this PR introduce a breaking change?
BREAKING CHANGE: App Services will require refactoring to use new interfaces and factory methods
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Start your review with these files, then the changes in the other files will make more sense.
Other information