refactor: Consolidate function pipeline configuration #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-wang-intel
requested changes
Mar 2, 2021
lenny-goodell
force-pushed
the
consolidate-pipeline-confg
branch
from
064259c to
81352d5
Compare
added 2 commits
March 2, 2021 14:54
Collapsed multiple function configurations by use of additional parameter and removed redundant configurations closes #725 BEAKING CHANGE: function pipeline configuration changed Signed-off-by: lenny <[email protected]>
Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
consolidate-pipeline-confg
branch
from
81352d5 to
14530c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
==========================================
- Coverage 66.04% 64.64% -1.40%
==========================================
Files 32 32
Lines 2082 2110 +28
==========================================
- Hits 1375 1364 -11
- Misses 618 652 +34
- Partials 89 94 +5
Continue to review full report at Codecov.
|
rsdmike
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Many function configurations have variations by name that can be consolidated to a single name with a new parameter for the variations.
Issue Number: #725
What is the new behavior?
Collapsed multiple function configurations by use of additional parameter and removed redundant configurations
See issue #725 for details about which function configurations changed.
Does this PR introduce a breaking change?
BEAKING CHANGE: function pipeline configuration changed
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information