Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: Clean up pipeline configuration for ASC to remove need to NoOps and redundant Post & Put function configurations #725

Closed
lenny-goodell opened this issue Feb 26, 2021 · 0 comments
Assignees
Labels
3-high priority denoting release-blocking issues app-services subsystem_affected for application services breaking change enhancement New feature or request
Milestone

Comments

@lenny-goodell
Copy link
Member

lenny-goodell commented Feb 26, 2021

Currently the ASC pipeline configuration has NoOps for a few functions that don't have parameters.

    [Writable.Pipeline.Functions.TransformToXML]
      [Writable.Pipeline.Functions.TransformToXML.Parameters]
      NoOp = "" # Must have at least one parameter for function to be populated in Consul
    [Writable.Pipeline.Functions.TransformToJSON]
      [Writable.Pipeline.Functions.TransformToJSON.Parameters]
      NoOp = "" # Must have at least one parameter for function to be populated in Consul
    [Writable.Pipeline.Functions.CompressWithGZIP]
      [Writable.Pipeline.Functions.CompressWithGZIP.Parameters]
      NoOp = "" # Must have at least one parameter for function to be populated in Consul
    [Writable.Pipeline.Functions.CompressWithZLIB]
      [Writable.Pipeline.Functions.CompressWithZLIB.Parameters]
      NoOp = "" # Must have at least one parameter for function to be populated in Consul

CompressWithGZIP & CompressWithZLIB can be combined into Compress with a Type parameter that must be GZIP or ZLIB
TransformToXML & TransformToJSON can be combined into Transform with a Type parameter that must be XML or JSON

Rename EncryptWithAES to Encrypt with the Algorithm parameter that must be AES allowing for future algorithms to be added with out adding new configuration items.

HTTPPost and HTTPPut can be combined to HttpExport with a Method parameter that must be POST or PUT

The following Post/Put function configurations are redundant and can be combined into one HTTPExport with addition method parameter.

    [Writable.Pipeline.Functions.HTTPPost]
    [Writable.Pipeline.Functions.HTTPPostJSON]
    [Writable.Pipeline.Functions.HTTPPostXML]
    [Writable.Pipeline.Functions.HTTPPut]
    [Writable.Pipeline.Functions.HTTPPutJSON]
    [Writable.Pipeline.Functions.HTTPPutXML]

For naming consistency, MQTTSecretSend can be renamed to MQTTExport.

The following Batch function configurations can be combined into Batch with a mode parameter that must be BatchByCount, BatchByTime or BatchByTimeAndCount.

[Writable.Pipeline.Functions.BatchByCount]
[Writable.Pipeline.Functions.BatchByTime]
[Writable.Pipeline.Functions.BatchByTimeAndCount]

Note: This is just for the pipeline configuration. The actual functions can stay as is. The configuration processing will use the new parameter to determine the correct function to add to the pipeline.

@lenny-goodell lenny-goodell changed the title SDK: Avoid need for NoOp in configuration for ASC by Combining some functions and adding Type parameter SDK: Avoid need for NoOp in configuration for ASC by Combining some pipeline function configurations and adding Type parameter Feb 26, 2021
@lenny-goodell lenny-goodell changed the title SDK: Avoid need for NoOp in configuration for ASC by Combining some pipeline function configurations and adding Type parameter SDK: Clean up pipeline configuration for ASC to remove need to NoOps and redundant Post & Put function configurations Feb 26, 2021
@lenny-goodell lenny-goodell added 3-high priority denoting release-blocking issues app-services subsystem_affected for application services breaking change enhancement New feature or request labels Feb 26, 2021
@lenny-goodell lenny-goodell added this to the Ireland milestone Feb 26, 2021
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Mar 2, 2021
Collapsed multpile function configurations by use of addtional parameter and removed redundent configurations

closes #725

Signed-off-by: lenny <[email protected]>
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Mar 2, 2021
Collapsed multpile function configurations by use of addtional parameter and removed redundent configurations

closes #725

BEAKING CHANGE: function pipeline configuration changed

Signed-off-by: lenny <[email protected]>
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Mar 2, 2021
Collapsed multpile function configurations by use of addtional parameter and removed redundent configurations

closes #725

BEAKING CHANGE: function pipeline configuration changed

Signed-off-by: lenny <[email protected]>
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Mar 2, 2021
Collapsed multiple function configurations by use of additional parameter and removed redundant configurations

closes #725

BEAKING CHANGE: function pipeline configuration changed

Signed-off-by: lenny <[email protected]>
lenny-goodell referenced this issue in lenny-goodell/app-functions-sdk-go Mar 2, 2021
Collapsed multiple function configurations by use of additional parameter and removed redundant configurations

closes #725

BEAKING CHANGE: function pipeline configuration changed

Signed-off-by: lenny <[email protected]>
@lenny-goodell lenny-goodell self-assigned this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-high priority denoting release-blocking issues app-services subsystem_affected for application services breaking change enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant