feat: Port service template from hanoi branch #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
requested review from
rsdmike,
AlexCuse,
jpwhitemn,
tonyespy and
jim-wang-intel
lenny-goodell
force-pushed
the
template
branch
3 times, most recently
from
198b5d6 to
c7d058f
Compare
Top level test target builds and tests the new template closes #674 Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
template
branch
from
c7d058f to
2f11d55
Compare
lenny-goodell
changed the title
AlexCuse
requested changes
Feb 17, 2021
Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
template
branch
from
07f62b3 to
1cc9f63
Compare
Removed top level bin folder. This eliminates duplication the script in this repo. Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
template
branch
2 times, most recently
from
04c5977 to
cb8e034
Compare
Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
template
branch
from
cb8e034 to
80f3533
Compare
AlexCuse
previously approved these changes
Feb 18, 2021
tonyespy
previously approved these changes
Feb 18, 2021
app-service-template/README.md
Outdated
|
|
||
| - `make build` | ||
|
|
||
| 7. Update the `makefile` docker build to adjust image name appropriately |
Signed-off-by: lenny <[email protected]>
lenny-goodell
dismissed stale reviews from tonyespy, AlexCuse, and jim-wang-intel
via
28ec641
jim-wang-intel
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No app service template on master branch
Issue Number: #674
What is the new behavior?
App service template on master branch (ported from hanoi branch)
Template references local SDK in the go.mod file so any changes in the SDk impact the template
make testnow runmake buildandmake teston the templateDoes this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information