Skip to content

Commit

Permalink
feat: Fixup - addressed PR comments
Browse files Browse the repository at this point in the history
Signed-off-by: lenny <[email protected]>
  • Loading branch information
lenny committed Feb 17, 2021
1 parent 2f11d55 commit 07f62b3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion app-service-template/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Application Service Template

This folder contains a buildable/runnable template for a new custom application service based on the Hanoi 1.3.1 release of the App Functions SDK.
This folder contains a buildable/runnable template for a new custom application service based on the Pre-Release 2.x release of the App Functions SDK.

> **Note**: If you only need to use the built-in pipeline functions, then it is advisable that you use `App Service Configurable` rather then create a new custom application service. See [here](https://docs.edgexfoundry.org/1.3/microservices/application/AppServiceConfigurable/) for more details on `App Service Configurable`
Expand Down
8 changes: 4 additions & 4 deletions app-service-template/functions/sample_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func TestSample_LogEventDetails(t *testing.T) {
expectedContinuePipeline := true

target := NewSample()
actualContinuePipeline, actualEvent := target.LogEventDetails(creatTestAppSdkContext(), expectedEvent)
actualContinuePipeline, actualEvent := target.LogEventDetails(createTestAppSdkContext(), expectedEvent)

assert.Equal(t, expectedContinuePipeline, actualContinuePipeline)
assert.Equal(t, expectedEvent, actualEvent)
Expand All @@ -49,7 +49,7 @@ func TestSample_ConvertEventToXML(t *testing.T) {
expectedContinuePipeline := true

target := NewSample()
actualContinuePipeline, actualXml := target.ConvertEventToXML(creatTestAppSdkContext(), event)
actualContinuePipeline, actualXml := target.ConvertEventToXML(createTestAppSdkContext(), event)

assert.Equal(t, expectedContinuePipeline, actualContinuePipeline)
assert.Equal(t, expectedXml, actualXml)
Expand All @@ -60,7 +60,7 @@ func TestSample_OutputXML(t *testing.T) {
testEvent := createTestEvent(t)
expectedXml, _ := testEvent.ToXML()
expectedContinuePipeline := false
appContext := creatTestAppSdkContext()
appContext := createTestAppSdkContext()

target := NewSample()
actualContinuePipeline, result := target.OutputXML(appContext, expectedXml)
Expand All @@ -87,7 +87,7 @@ func createTestEvent(t *testing.T) dtos.Event {
return event
}

func creatTestAppSdkContext() *appcontext.Context {
func createTestAppSdkContext() *appcontext.Context {
return &appcontext.Context{
CorrelationID: uuid.New().String(),
LoggingClient: logger.NewMockClient(),
Expand Down

0 comments on commit 07f62b3

Please sign in to comment.