Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Additional committed metrics #1116

Closed
4 tasks done
lenny-goodell opened this issue May 23, 2022 · 0 comments · Fixed by #1123, #1132, #1133 or #1137
Closed
4 tasks done

[SDK] Additional committed metrics #1116

lenny-goodell opened this issue May 23, 2022 · 0 comments · Fixed by #1123, #1132, #1133 or #1137
Labels
enhancement New feature or request
Milestone

Comments

@lenny-goodell
Copy link
Member

lenny-goodell commented May 23, 2022

Decided on the following committed list for SDK in 5/31/22 WG Meeting

  • Size of data exported via HTTP
  • Size of data exported via MQTT
  • Number of invalid messages received (i.e. error decoding)
  • Number of errors that terminate a pipeline (per pipeline)

Use separate PRs for each of above and check them off once complete.

Background Info

The Metrics ADR has this potential list for App Services not completed in Kamakura:

  • DB access times
    • Only use DB for S&F (Store & Forward). Value of this?
  • How often are we failing export to be sent to db to be retried at a later time
    • Again, only S&F. How does this diffed than the next one.
  • What is the current store and forward queue size
    • This is interesting since this would be hard to monitor off box is system not connected, i.e. utilizing S&F... ;-)
    • Collection continues and but reporting would only be available for when system is on-line. I.e collector could use S7F w/o collecting metrics on itself...
  • How much data (size in KBs or MBs) of packaged sensor data is being sent to an endpoint (or volume)
    • This would be in the HTTP and MQTT exports. Two separate metrics?
  • Number of invalid messages that triggered pipeline
    • This allows monitoring is App Service is operational wrt processing incoming message, i.e. TargetType may not match the incoming data.

Completed in Kamakura:

  • Processing time for a pipeline (PipelineMessageProcessingTime)
    • latency (measure of time) an event takes to get through an application service pipeline
    • This is per pipeline now since a service can have multiple pipelines. The metric gets reported for each pipeline with the pipeline ID as the tag.
  • Number of events processed by each pipeline (PipelineMessagesProcessed )
    • This is per pipeline now since a service can have multiple pipelines. The metric gets reported for each pipeline with the pipeline ID as the tag.
  • Number of events processed by the service (MessagesReceived)

Decided on the following list for SDK:

  • Size of data exported (HTTP and MQTT)
    • Requires Meter metric type to be added.
  • Number of invalid messages received (i.e. error decoding)
  • Number of errors that terminate a pipeline (per pipeline)
  • What is the current store and forward queue size (stretch)
  • Message latency for received from MessageBus to hand off to Pipeline (stretch)
@lenny-goodell lenny-goodell added this to the Levski milestone May 23, 2022
@lenny-goodell lenny-goodell added the enhancement New feature or request label May 24, 2022
lenny-goodell pushed a commit to lenny-goodell/app-functions-sdk-go that referenced this issue Jun 15, 2022
lenny-goodell pushed a commit to lenny-goodell/app-functions-sdk-go that referenced this issue Jun 15, 2022
@lenny-goodell lenny-goodell linked a pull request Jun 15, 2022 that will close this issue
5 tasks
lenny-goodell pushed a commit that referenced this issue Jun 16, 2022
* feat: Add InvalidMessagesReceived service metric

apply to #1116

Signed-off-by: Leonard Goodell <[email protected]>
@lenny-goodell lenny-goodell reopened this Jun 17, 2022
@lenny-goodell lenny-goodell moved this to In Progress in Application Services Jun 22, 2022
ejlee3 added a commit to ejlee3/app-functions-sdk-go that referenced this issue Jun 23, 2022
ejlee3 added a commit to ejlee3/app-functions-sdk-go that referenced this issue Jun 23, 2022
ejlee3 added a commit to ejlee3/app-functions-sdk-go that referenced this issue Jun 23, 2022
lenny-goodell pushed a commit that referenced this issue Jun 23, 2022
…rsion (#1132)

* feat(metrics): add http size to metrics, updates for new bootstrap version

apply to #1116

Signed-off-by: Elizabeth J Lee <[email protected]>
lenny-goodell pushed a commit to lenny-goodell/app-functions-sdk-go that referenced this issue Jun 23, 2022
lenny-goodell pushed a commit to lenny-goodell/app-functions-sdk-go that referenced this issue Jun 23, 2022
lenny-goodell pushed a commit to lenny-goodell/app-functions-sdk-go that referenced this issue Jun 27, 2022
lenny-goodell pushed a commit that referenced this issue Jun 27, 2022
Repository owner moved this from In Progress to Done in Application Services Jun 27, 2022
@lenny-goodell lenny-goodell reopened this Jun 27, 2022
@lenny-goodell lenny-goodell moved this from Done to In Progress in Application Services Jun 28, 2022
ejlee3 added a commit to ejlee3/app-functions-sdk-go that referenced this issue Jun 29, 2022
lenny-goodell pushed a commit that referenced this issue Jun 30, 2022
* feat: add metric to capture mqtt size in bytes

applies to #1116
@lenny-goodell lenny-goodell linked a pull request Jun 30, 2022 that will close this issue
5 tasks
@lenny-goodell lenny-goodell moved this from In Progress to Done in Application Services Jun 30, 2022
@lenny-goodell lenny-goodell changed the title [SDK] Additional metrics [SDK] Additional committed metrics Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment