Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missed ServiceName in Swagger #1033

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Conversation

AlexCuse
Copy link
Contributor

Add for Ping, Config, Metrics, Version DTOs.

Signed-off-by: Alex Ullrich [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
    n/a
  • I have opened a PR for the related docs change (if not, why?)
    n/a

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

Codecov Report

Merging #1033 (b00dd47) into main (b262707) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1033   +/-   ##
=======================================
  Coverage   68.97%   68.97%           
=======================================
  Files          36       36           
  Lines        2856     2856           
=======================================
  Hits         1970     1970           
  Misses        777      777           
  Partials      109      109           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b262707...b00dd47. Read the comment docs.

@AlexCuse AlexCuse linked an issue Jan 27, 2022 that may be closed by this pull request
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix Attribution file for missed removal of old go-kit entry. THX!

Add for Ping, Config, Metrics, Version DTOs.

Signed-off-by: Alex Ullrich <[email protected]>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 1fe855a into edgexfoundry:main Jan 27, 2022
FelixTing pushed a commit to FelixTing/app-functions-sdk-go that referenced this pull request Mar 3, 2022
Add for Ping, Config, Metrics, Version DTOs.

Signed-off-by: Alex Ullrich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include ServiceName in Common Responses
3 participants