Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include ServiceName in Common Responses #1027

Closed
AlexCuse opened this issue Jan 25, 2022 · 0 comments · Fixed by #1029 or #1033
Closed

Include ServiceName in Common Responses #1027

AlexCuse opened this issue Jan 25, 2022 · 0 comments · Fixed by #1029 or #1033
Assignees
@AlexCuse
Milestone
Kamakura

Comments

@AlexCuse
Copy link
Contributor

As of go-mod-core-contracts v2.2.0-dev.9 ServiceName is available on the following responses:

  • ping
  • version
  • metrics
  • config

Will need to update SDK and use the new constructors
@lenny-goodell lenny-goodell added this to the Kamakura milestone Jan 25, 2022
AlexCuse added a commit to AlexCuse/app-functions-sdk-go that referenced this issue Jan 26, 2022
@AlexCuse
feat: Create Common DTOs with ServiceName
b9726ea 
Included on Ping, Version, Config and Metrics responses.

Fixes edgexfoundry#1027

Signed-off-by: Alex Ullrich <[email protected]>
@AlexCuse AlexCuse mentioned this issue Jan 26, 2022
Merged
5 tasks
AlexCuse added a commit to AlexCuse/app-functions-sdk-go that referenced this issue Jan 26, 2022
@AlexCuse
feat(webserver): Create Common DTOs with ServiceName
d78c9c1 
Included on Ping, Version, Config and Metrics responses.

Fixes edgexfoundry#1027

Signed-off-by: Alex Ullrich <[email protected]>
AlexCuse added a commit to AlexCuse/app-functions-sdk-go that referenced this issue Jan 26, 2022
@AlexCuse
feat(webserver): Create Common DTOs with ServiceName
a1a671a 
Included on Ping, Version, Config and Metrics responses.

Fixes edgexfoundry#1027

Signed-off-by: Alex Ullrich <[email protected]>
lenny-goodell pushed a commit that referenced this issue Jan 26, 2022
@AlexCuse
feat(webserver): Create Common DTOs with ServiceName (#1029)
3b5051e 
Included on Ping, Version, Config and Metrics responses.

Fixes #1027

Signed-off-by: Alex Ullrich <[email protected]>
AlexCuse added a commit to AlexCuse/app-functions-sdk-go that referenced this issue Jan 26, 2022
@AlexCuse
feat(webserver): Create Common DTOs with ServiceName
a788bbe 
Included on Ping, Version, Config and Metrics responses.

Fixes edgexfoundry#1027

Signed-off-by: Alex Ullrich <[email protected]>
@AlexCuse AlexCuse linked a pull request Jan 27, 2022 that will close this issue
fix: Missed ServiceName in Swagger #1033
Merged
5 tasks
FelixTing pushed a commit to FelixTing/app-functions-sdk-go that referenced this issue Mar 3, 2022
@AlexCuse @FelixTing
feat(webserver): Create Common DTOs with ServiceName (edgexfoundry#1029)
dcd4402 
Included on Ping, Version, Config and Metrics responses.

Fixes edgexfoundry#1027

Signed-off-by: Alex Ullrich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexCuse AlexCuse

Labels
None yet
Projects
None yet
Milestone
Kamakura
2 participants
@AlexCuse @lenny-goodell