Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jason,
I have a couple more minor fixes and enhancements for you. Also, I took your advice and wrote a custom hiera backend for trocla for generation of the kdc database password. Have a look at duritong/puppet-trocla#15 if you're interested.
Avoid error message 'Error: Could not retrieve catalog from remote server:
Error 400 on SERVER: Function 'fail' does not return a value at
/etc/puppet/modules/kerberos/manifests/kdc/master.pp:41 on node ...'.
With this change it to correctly aborts with 'Error 400 on SERVER:
kdc_database_password must be set at
/etc/puppet/modules/kerberos/manifests/kdc/master.pp:41 on node ...'.