Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coordinator: fix equality checks for manifest properties #777

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

coordinator: fix equality checks for manifest properties #777

wants to merge 2 commits into from

Conversation

daniel-weisse
Copy link
Member

two missing checks were preventing manifest updates from being properly applied if only these values changed

Proposed changes

  • fix missing check for DisableSecretBinding in manifest.Marble.Equal
  • fix missing check for AcceptedTCBStatuses and AcceptedAdvisories in quote.PackageProperties.Equal

@daniel-weisse daniel-weisse added the bug fix This change fixes a user facing bug from the previous release label Dec 12, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for marblerun-docs canceled.

Name Link
🔨 Latest commit 0607107
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/675c523949f1970008fc5b7d

thomasten
thomasten approved these changes Dec 13, 2024
View reviewed changes
coordinator/manifest/manifest.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasten thomasten thomasten approved these changes

Assignees
No one assigned
Labels
bug fix This change fixes a user facing bug from the previous release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-weisse @thomasten