Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packages: add nvidia OCI hook for peer pods #956

Merged
merged 3 commits into from
Nov 11, 2024
Merged

packages: add nvidia OCI hook for peer pods #956

merged 3 commits into from
Nov 11, 2024

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Oct 28, 2024

This enables the podvm-image package for use in GPU peer pods by doing the following:

  • Adding a preconfigured nvidia-ctk package for use with peer pods GPU containers.
  • Adding a package for the OCI hook required to start peer pods GPU containers.
  • Placing the OCI hook in the expected path in the podvm-image if GPU use is configured.

@msanft msanft added the no changelog PRs not listed in the release notes label Oct 28, 2024
@msanft msanft requested a review from katexochen as a code owner October 28, 2024 12:21
@msanft msanft requested a review from Freax13 October 28, 2024 12:21
@msanft msanft force-pushed the msanft/packages/nvidia-oci-hook branch 2 times, most recently from 2b62dd5 to 12628c4 Compare October 28, 2024 12:33
@katexochen
Copy link
Member 

       error: evaluation aborted with the following error message: 'lib.customisation.callPackageWith: Function called without required argument "libnvidia-container-custom" at /nix/store/dvppxran2w1d1jgs7lhrih6012vmd24l-source/packages/by-name/nvidia-ctk-with-config/package.nix:9'

I guess this depends on another PR? Wrong base?

msanft added 3 commits November 4, 2024 11:46
@msanft
packages/nvidia-ctk-with-config: init
3dcfdf7 
This adds a preconfigured `nvidia-ctk` package for use with peer pods GPU containers.
@msanft
packages/nvidia-ctk-oci-hook: init
2f7e456 
This adds a package for the OCI hook required to start peer pods GPU containers.
@msanft
packages/nixos: place nvidia-ctk-oci-hook in image
219147e 
This places the OCI hook in the expected path in the podvm-image if GPU use is configured.
@msanft msanft requested a review from Freax13 November 4, 2024 10:46
@msanft msanft force-pushed the msanft/packages/nvidia-oci-hook branch from 12628c4 to 219147e Compare November 4, 2024 10:53
@msanft msanft merged commit 579e51f into main Nov 11, 2024
10 checks passed
@msanft msanft deleted the msanft/packages/nvidia-oci-hook branch November 11, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@Freax13 Freax13 Freax13 approved these changes

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msanft @katexochen @Freax13