some fixes to the runtime cleanup #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why this was there in the first place. AFAICT that flag doesn't exist and grep already sets the exit code depending on whether or not a match was found.
grep returns 1 if no match is found. Don't do that, we don't want to fail here.
Freax13
force-pushed
the
tom/fix-cleanup
branch
11 times, most recently
from
9756877 to
52f7a99
Compare
katexochen
reviewed
Oct 28, 2024
katexochen
reviewed
Oct 28, 2024
Removing the data directories for the snapshotters isn't quite enough, we also need to tell containerd to clean up its state.
For some reason, ghcr.io won't let use upload a package named cleanup-bm, but it let's us upload other packages. Renaming the package fixes the issue.
Freax13
force-pushed
the
tom/fix-cleanup
branch
from
52f7a99 to
8ad6fef
Compare
katexochen
reviewed
Oct 28, 2024
We don't care about properly versioning the cleanup-bare-metal image, so let's just use latest. Kubernetes will always pull the image if the tag is `latest`.
katexochen
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that we need to fix the containerd state after removing the data folders for the snapshotters, otherwise containers won't start anymore.