Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix missing "current version" in commit message from bump_version action #710

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

daniel-weisse
Copy link
Member

The action was missing an initialization of the current variable.
This leads to the current version being omitted from the commit message.
See f7c10e6 for example.

Load current version from version.txt before writing the new version to fix this.

@daniel-weisse daniel-weisse added the no changelog PRs not listed in the release notes label Jul 11, 2024
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, this has been broken for quite some time. 😅 Good catch and thanks for the fix!

@katexochen katexochen added this to the v0.8.0 milestone Jul 11, 2024
@katexochen katexochen merged commit 6806e7b into main Jul 11, 2024
6 of 9 checks passed
@katexochen katexochen deleted the dw/fix-ci-version-commit-msg branch July 11, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants